-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repo jbake-maven-plugin into repo jbake + upgrade to gradle 7 #740
Add repo jbake-maven-plugin into repo jbake + upgrade to gradle 7 #740
Conversation
--HG-- extra : amend_source : 31da5144387b274a1c962c35dbcb7746cab6c34a
--HG-- rename : src/main/java/br/com/ingenieux/mojo/jbake/GenerateMojo.java => src/main/java/br/com/ingenieux/mojo/jbake/SeedMojo.java
…. use freefair maven plugin
…nd put stuff where it belongs
plugins are not configured currently because I was to lazy to configure a combined jacoco report.
Thanks @lefou for taking the time to share your thoughts on this, it is very much appreciated. 👍 There are negatives, as you quite rightly point out, but I think the potential positives will outweigh the negatives overall. Especially for users and that is the goal for this. |
… dependency by default
…cluded out of the box
Conducted some local testing and the plugin builds and executes as expected in a sample Maven project. I compared the generated artefact to a previous version and noticed a few things. The pom.xml for the plugin is missing metadata about the plugin (name, license, SCM etc.) and a HelpMojo class is missing (guessing this was automatically generated). Couldn't remember if the metadata is required for Maven Central so did a check and found this: https://central.sonatype.org/publish/requirements/ which suggests it is. |
switch back to maven plugin development gradle plugin from Benedikt Ritter https://github.com/britter/maven-plugin-development
Have a look at the latest commit here https://github.com/ancho/jbake/tree/merge-repo-jbake-maven-plugin |
Thanks @ancho that's solved it, with that commit I get the metadata and the HelpMojo class. |
Thanks @ancho! Great work! |
1. version bumps resolve platform incompatibilities on non-x86 platforms ``` [ERROR] Failed to execute goal org.jbake:jbake-maven-plugin:0.3.6-rc.2:generate (default) on project drools-website: Execution default of goal org.jbake:jbake-maven-plugin:0.3.6-rc.2:generate failed: An API incompatibility was encountered while executing org.jbake:jbake-maven-plugin:0.3.6-rc.2:generate: java.lang.UnsatisfiedLinkError: ... (fat file, but missing compatible architecture (have 'i386,x86_64', need 'arm64')) ``` 2. avoid the need to specify manually jbake-maven-plugin dependencies version ref: jbake-org/jbake#740
1. version bumps resolve platform incompatibilities on non-x86 platforms ``` [ERROR] Failed to execute goal org.jbake:jbake-maven-plugin:0.3.6-rc.2:generate (default) on project drools-website: Execution default of goal org.jbake:jbake-maven-plugin:0.3.6-rc.2:generate failed: An API incompatibility was encountered while executing org.jbake:jbake-maven-plugin:0.3.6-rc.2:generate: java.lang.UnsatisfiedLinkError: ... (fat file, but missing compatible architecture (have 'i386,x86_64', need 'arm64')) ``` 2. avoid the need to specify manually jbake-maven-plugin dependencies version ref: jbake-org/jbake#740
Tackles these issues:
Keep it simple for users: If a new JBake version comes out, I just update my jbake-maven-plugin version, done. No need to figure out which maven/gradle plugin version aligns to which jbake version (for every jbake upgrade too).