remove PQ test of threshold searches pending #254

jbellis · Mar 20, 2024 · de0ed47 · de0ed47
1 parent 26b5d11
commit de0ed47
Showing 1 changed file with 22 additions and 21 deletions.
diff --git a/jvector-tests/src/test/java/io/github/jbellis/jvector/graph/Test2DThreshold.java b/jvector-tests/src/test/java/io/github/jbellis/jvector/graph/Test2DThreshold.java
@@ -68,27 +68,28 @@ public void testThreshold(int graphSize, int maxDegree) throws IOException {
         }
 
         // test compressed
-        Path outputPath = Files.createTempFile("graph", ".jvector");
-        TestUtil.writeGraph(onHeapGraph, ravv, outputPath);
-        var pq = ProductQuantization.compute(ravv, ravv.dimension(), 256, false);
-        var cv = new PQVectors(pq, pq.encodeAll(List.of(vectors)));
-
-        try (var marr = new SimpleMappedReader(outputPath.toAbsolutePath().toString());
-             var onDiskGraph = new OnDiskGraphIndex(marr::duplicate, 0);
-             var view = onDiskGraph.getView())
-        {
-            for (int i = 0; i < 10; i++) {
-                TestParams tp = createTestParams(vectors);
-                searcher = new GraphSearcher.Builder(onDiskGraph.getView()).build();
-                var reranker = NodeSimilarity.Reranker.from(tp.q, VectorSimilarityFunction.EUCLIDEAN, view);
-                var asf = cv.approximateScoreFunctionFor(tp.q, VectorSimilarityFunction.EUCLIDEAN);
-                var result = searcher.search(asf, reranker, vectors.length, tp.th, Bits.ALL);
-
-                // System.out.printf("visited %d to find %d/%d results for threshold %s%n", result.getVisitedCount(), result.getNodes().length, tp.exactCount, tp.th);
-                assert result.getVisitedCount() < vectors.length : "visited all vectors for threshold " + tp.th;
-                assert result.getNodes().length >= 0.9 * tp.exactCount : "returned " + result.getNodes().length + " nodes for threshold " + tp.th + " but should have returned at least " + tp.exactCount;
-            }
-        }
+        // FIXME see https://github.com/jbellis/jvector/issues/254
+//        Path outputPath = Files.createTempFile("graph", ".jvector");
+//        TestUtil.writeGraph(onHeapGraph, ravv, outputPath);
+//        var pq = ProductQuantization.compute(ravv, ravv.dimension(), 256, false);
+//        var cv = new PQVectors(pq, pq.encodeAll(List.of(vectors)));
+//
+//        try (var marr = new SimpleMappedReader(outputPath.toAbsolutePath().toString());
+//             var onDiskGraph = new OnDiskGraphIndex(marr::duplicate, 0);
+//             var view = onDiskGraph.getView())
+//        {
+//            for (int i = 0; i < 10; i++) {
+//                TestParams tp = createTestParams(vectors);
+//                searcher = new GraphSearcher.Builder(onDiskGraph.getView()).build();
+//                var reranker = NodeSimilarity.Reranker.from(tp.q, VectorSimilarityFunction.EUCLIDEAN, view);
+//                var asf = cv.approximateScoreFunctionFor(tp.q, VectorSimilarityFunction.EUCLIDEAN);
+//                var result = searcher.search(asf, reranker, vectors.length, tp.th, Bits.ALL);
+//
+//                // System.out.printf("visited %d to find %d/%d results for threshold %s%n", result.getVisitedCount(), result.getNodes().length, tp.exactCount, tp.th);
+//                assert result.getVisitedCount() < vectors.length : "visited all vectors for threshold " + tp.th;
+//                assert result.getNodes().length >= 0.9 * tp.exactCount : "returned " + result.getNodes().length + " nodes for threshold " + tp.th + " but should have returned at least " + tp.exactCount;
+//            }
+//        }
     }
 
     /**