Set up CI with Azure Pipelines #96
Conversation
|
@chrisrpatterson you mentioned over in pandas that you may be able to help with azure-pipelines setup. Can I ping you for help on a much less-popular project? I think I've gotten most of the config put together. What I'm still stuck on is the fact that the pipeline is showing Green here on the PR page while there is still a failing test in the most recent log. Have I missed a config option somewhere? |
|
The publish test results task will not fail the build based on failed test results alone. You will need to have the test script return a non-zero exit code to fail the build. |
Thanks for the quick feedback. If you're not the right person to ask about this, let me know and I'll stop bugging you. I copied the pandas version as closely as possible, cannot tell where the relevant difference is. AFACT the pytest call here should return a non-zero exit code, which should in turn mean a non-zero return code here. Is it obvious why this works for pandas but not here? |
|
@bashtage any interest in helping troubleshoot this? I'm kind of hoping that once the config is figured out once it can be shared here/arch/linearmodels/statsmodels |
|
I don't feel a lot of pressure to have higher performance CI, and setup seems to be challenging. |
ci/script_single.sh
Outdated
|
|
||
| exit "$RET" | ||
| exit $RET |
There was a problem hiding this comment.
WHy not just exit 1 to see if this is the issue?
ci/azure/macos.yml
Outdated
| ci/script_single.sh | ||
| echo $? | ||
| ci/script_multi.sh | ||
| echo $? |
There was a problem hiding this comment.
The publish test results task will not fail the build based on failed test results alone. You will need to have the test script return a non-zero exit code to fail the build.
@chrisrpatterson both here and two lines above I'm seeing a 1, as expected. Is there somewhere else where a non-zero exit code needs to be returned?
There was a problem hiding this comment.
Can you try adding set -o pipefail as the first line of your script? I suspect echo returns non-zero and it is the last line.
There was a problem hiding this comment.
@chrisrpatterson thanks for the suggestion. Added that on line 34 above, no clear difference.
No description provided.