Refactor _release_file function

jdavcs · Nov 26, 2024 · f1ec350 · f1ec350
1 parent 3f2a6cd
commit f1ec350
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/galaxy_release_util/bootstrap_history.py b/galaxy_release_util/bootstrap_history.py
@@ -41,6 +41,7 @@
 RELEASE_DELTA_MONTHS = 4  # Number of months between releases.
 MINOR_TO_MONTH = {0: 2, 1: 6, 2: 10}
 FREEZE_TO_RELEASE_DELTA_DAYS = 21  # Default number of days from freeze to release
+OLDER_RELEASES_FILENAME = "older_releases.rst"
 
 
 TEMPLATE = """
@@ -660,12 +661,10 @@ def _get_release_notes_filenames(galaxy_root):
     return sorted(os.listdir(releases_path))
 
 
-def _release_file(galaxy_root: Path, release: Optional[str]) -> str:  # TODO: check this!
+def _release_file(galaxy_root: Path, filename: Optional[str]) -> str:
+    """Construct and return path to a release documentation file."""
     releases_path = galaxy_root / "doc" / "source" / "releases"
-    if release is None:
-        release = sorted(os.listdir(releases_path))[-1]
-    history_path = os.path.join(releases_path, release)
-    return history_path
+    return os.path.join(releases_path, filename or OLDER_RELEASES_FILENAME)
 
 
 def process_sentence(message):  # TODO: check this!