JENKINS-73653: Update to Amazon SDK v2 #195
Open
+64
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiX
commented
Jan 17, 2025
| @@ -60,30 +61,40 @@ public class AmazonECSRegistryCredential extends BaseStandardCredentials | |||
|
|
|||
| private final String credentialsId; | |||
|
|
|||
| private final Regions region; | |||
| private final String region; | |||
There was a problem hiding this comment.
Spotbugs complained about "non-transient non-serializable instance field region" when using the new Region class here, so I just used a String...
Closed
|
That issue report is a duplicate, and the issue has already been fixed. This PR is beneficial in general, but any upgrade from v1 to v2 needs to be manually tested with a real AWS account before it can be released to end users. |
basil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS SDK 1.x is end-of-life and this update should be done before the end of 2025...
Ping @basil: If you have some time for a review...
Testing done
My test case still runs, not sure if it tests enough...
Submitter checklist