Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality fix - The members of an interface declaration or class should appear in a pre-defined order (part 1) #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed rule 'The members of an interface declaration or class should a…
…ppear in a pre-defined order' (Part 1)
SosoTughushi committed Jun 26, 2016
commit ed6dee6a004aba188e21c6f8b569793d8a81ee14
Original file line number Diff line number Diff line change
@@ -11,6 +11,12 @@
import static net.serenitybdd.screenplay.Tasks.instrumented;

public class HaveAFolderCreated implements Task {
private final String name;
private final TodoList configurationTasks = TodoList.empty();

public HaveAFolderCreated(String name) {
this.name = name;
}

public static HaveAFolderCreated called(String name) {
return instrumented(HaveAFolderCreated.class, name);
@@ -31,11 +37,4 @@ public <T extends Actor> void performAs(T actor) {
Click.on(FolderDetailsPage.Up_Link)
);
}

public HaveAFolderCreated(String name) {
this.name = name;
}

private final String name;
private final TodoList configurationTasks = TodoList.empty();
}
Original file line number Diff line number Diff line change
@@ -11,6 +11,12 @@

public class HaveANestedProjectCreated implements Task {

private final String projectName;

public HaveANestedProjectCreated(String projectName) {
this.projectName = projectName;
}

public static Task called(String name) {
return instrumented(HaveANestedProjectCreated.class, name);
}
@@ -24,9 +30,5 @@ public <T extends Actor> void performAs(T actor) {
);
}

public HaveANestedProjectCreated(String projectName) {
this.projectName = projectName;
}

private final String projectName;
}
Original file line number Diff line number Diff line change
@@ -15,6 +15,13 @@
import static org.openqa.selenium.Keys.ENTER;

public class CreateAFolder implements Task {

private final String name;

public CreateAFolder(String jobName) {
this.name = jobName;
}

public static CreateAFolder called(String name) {
return instrumented(CreateAFolder.class, name);
}
@@ -30,9 +37,4 @@ public <T extends Actor> void performAs(T actor) {
);
}

public CreateAFolder(String jobName) {
this.name = jobName;
}

private final String name;
}
Original file line number Diff line number Diff line change
@@ -4,18 +4,22 @@

public class RemoteRepository {

public static RemoteRepository at(String url) {
URI remote = URI.create(url);

return new RemoteRepository(remote.getHost(), "default", remote.toString());
}
private final String id;
private final String type;
private final String url;

public RemoteRepository(String id, String type, String url) {
this.id = id;
this.type = type;
this.url = url;
}

public static RemoteRepository at(String url) {
URI remote = URI.create(url);

return new RemoteRepository(remote.getHost(), "default", remote.toString());
}

public String id() {
return id;
}
@@ -27,8 +31,4 @@ public String type() {
public String url() {
return url;
}

private final String id;
private final String type;
private final String url;
}
Original file line number Diff line number Diff line change
@@ -9,6 +9,12 @@

public class ProjectWidget {

private final String projectOfInterest;

public ProjectWidget(String projectOfInterest) {
this.projectOfInterest = projectOfInterest;
}

public static ProjectWidget of(String projectOfInterest) {
return new ProjectWidget(projectOfInterest);
}
@@ -25,9 +31,4 @@ public Question<String> details() {
return new ProjectWidgetDetails(projectOfInterest);
}

public ProjectWidget(String projectOfInterest) {
this.projectOfInterest = projectOfInterest;
}

private final String projectOfInterest;
}