Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use test name in GitCommandsExecutorTest test data #1246

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

MarkEWaite
Copy link
Contributor

Use test name in GitCommandsExecutorTest test data

Assure that any failures clearly identify themselves.

Replace two utility methods with calls to construct good and bad command objects.

Testing done

Confirmed that automated tests pass on Linux with Java 21. Rely on ci.jenkins.io for Windows tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Assure that any failures clearly identify themselves.

Replace two utility methods with calls to construct good and bad
command objects.
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Jan 17, 2025
@MarkEWaite MarkEWaite requested a review from a team as a code owner January 17, 2025 03:12
@github-actions github-actions bot added the tests Automated test addition or improvement label Jan 17, 2025
@MarkEWaite MarkEWaite removed the tests Automated test addition or improvement label Jan 17, 2025
@MarkEWaite MarkEWaite merged commit b1c1eed into jenkinsci:master Jan 17, 2025
18 checks passed
@MarkEWaite MarkEWaite deleted the use-testName-in-test-data branch January 17, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant