Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74121] Remove inline onClick handlers in WinBatchBuildStep/config.jelly #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shlomomdahan
Copy link

@shlomomdahan shlomomdahan commented Dec 5, 2024

JENKINS-74121

Note:

There is an onclick Handler on the Add Argument button however it looks like the functionality was previously removed. I removed it and it does not affect the functionality at all. relevant commit

Testing done

Before Changes:

Screen.Recording.2024-12-05.at.6.20.56.PM.mov

After Changes:

Screen.Recording.2024-12-05.at.6.22.34.PM.mov

Steps to reproduce test:

  1. Go to Manage Jenkins -> Managed Files -> Add new config file
  2. Select 'Managed Windows Batch File` -> Save and submit.
  3. Create Freestyle Project -> In Build Steps select: Execute Managed Windows Batch
  4. Select the script create above -> Here you will see the code changed:
    i. view selected file
    ii. Add Argument

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant