Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74120] Remove inline js script in ScriptConfig/edit-config.jelly #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shlomomdahan
Copy link

JENKINS-74120

Removes inline javascript to comply with CSP.

Testing done

After Changes:

Screen.Recording.2024-12-05.at.8.24.52.PM.mov
  1. Go to Manage Jenkins -> Managed Files -> Add new config file
  2. Select 'Managed Script File` -> Save and submit.
  3. Go back to Managed files and click Edit Files
  4. Click edit button next to the file you just created
  5. type #! python into the text area and save
  6. When page is refreshed you should see it is recognizing the text as python.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant