Fix #287 #288
Fix #287 #288
Conversation
src/index.ts
Outdated
| @@ -220,7 +222,8 @@ function getPmtInf( | |||
| ); | |||
| } | |||
|
|
|||
| if (options?.checkBIC && !isValidBIC(item.bic)) { | |||
| const bicOptional = PAIN_TYPES[painFormat] === "CstmrCdtTrfInitn"; | |||
There was a problem hiding this comment.
| const bicOptional = PAIN_TYPES[painFormat] === "CstmrCdtTrfInitn"; | |
| const bicOptional = PAIN_TYPES[painFormat] === "CstmrDrctDbtInitn"; |
There was a problem hiding this comment.
I don't think this is correct, because then pain.001.001.03 and pain.001.003.03 will support optional bic and not pain.008.001.02 and pain.008.003.02
There was a problem hiding this comment.
Hi @jerebtw, pain.001... are for credit transfers, and pain.008 are for direct debit, which is where bic is optional. That's why I think that the bic optional variable shouod be true if pain type is CstmrDrctDbtInitn (which are pain.008...) and not CstmrCdtTrfInitn (which are pain.001...)
There was a problem hiding this comment.
To make it even easier, I think credit transfers also allow bic optional, as this article says
Since February 2016, the ‘IBAN only’ rule has been in force, and makes SEPA payments even easier for consumers and corporates. When they make euro credit transfers or direct debits in SEPA, they are no longer asked to provide the BIC of the payer or payee because the IBAN is sufficient to process the transaction. PSPs can consult databases provided by various suppliers in order to link the IBAN to the BIC.
There was a problem hiding this comment.
I see, thanks okay, I will change that and release a new version.
Co-authored-by: Daniel Reinón García <[email protected]>
This reverts commit a22e39d.
This reverts commit 7207fb4.
No description provided.