Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for custom http clients to be provided #105

Merged
merged 1 commit into from
Dec 4, 2023
Merged

feat: allow for custom http clients to be provided #105

merged 1 commit into from
Dec 4, 2023

Conversation

nscuro
Copy link
Contributor

@nscuro nscuro commented Dec 2, 2023

The ability to customize clients makes it easier to integrate this library into applications more smoothly. Applications may wish to set custom User-Agent headers, configure proxies through ways other than Java system properties, hook in metrics collection, and more.

@jeremylong
Copy link
Owner

Thanks for the PR - it may take a few days for me to find time to review and publish the next version.

The ability to customize clients makes it easier to integrate this library into applications more smoothly. Applications may wish to set custom `User-Agent` headers, configure proxies through ways other than Java system properties, hook in metrics collection, and more.

Signed-off-by: nscuro <[email protected]>
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit c936e6b into jeremylong:main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants