Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kill signal handling #244 #246

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Fix kill signal handling #244 #246

merged 2 commits into from
Jan 12, 2025

Conversation

EugenMayer
Copy link
Contributor

@EugenMayer EugenMayer commented Jan 8, 2025 •
edited
Loading

Fixes #244

  • use exec to replace the bash script, not fork a different process
  • use dedicated validate process

@EugenMayer
Copy link
Contributor Author

AFAICS the violations have not been cause by this PR but rather are present on the main branch already

@EugenMayer EugenMayer changed the title Add a trap for proper shutdown fixes #244 Fix kill signal handling #244 Jan 8, 2025
jeremylong
jeremylong approved these changes Jan 12, 2025
View reviewed changes
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit 4638271 into jeremylong:main Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylong jeremylong jeremylong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker image does not properly listens for sigterm
2 participants
@EugenMayer @jeremylong