fix: Reimplement caching to use a per-year scope #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reimplement caching to use a per-year scope * Add forgiveness if a year fails, continue to the next one * Reimplement how the lastUpdated date is used and stored per year * Add lockfile * fix: preserve modified entries if year fails * polish docs, add exit code --------- Co-authored-by: Jeremy Long <[email protected]>
* fix: bugfix in yearly cache update * fix: ensure sorted * fix: updated modified date in properties
* feat: retry nvd cache on failure * fix: updated per peer review
|
moved comment to pr #279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change was reverted in master - original proposed via #259.
While the idea is good and we may go with it; I am concerned about the number of requests on an update that could be completed with a single API request. I have questions out to the team at the NVD that I'm waiting on an answer.