Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to save and open dataset #38

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

Billyzhang1229
Copy link
Contributor

@Billyzhang1229 Billyzhang1229 commented Sep 21, 2022

@coveralls
Copy link

coveralls commented Sep 21, 2022

Pull Request Test Coverage Report for Build 3099046953

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 14 (85.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 97.2%

Changes Missing Coverage Covered Lines Changed/Added Lines %
phylokit/dataset.py 10 12 83.33%
Totals Coverage Status
Change from base Build 2954999796: -0.3%
Covered Lines: 486
Relevant Lines: 500

💛 - Coveralls

@jeromekelleher
Copy link
Owner

Looks like a bunch of unrelated parsimony stuff included here. Simplest thing would be to rebase this PR on upstream/main and to drop all but the last commit. (But make sure you have a backup of these commits on another branch!)

Copy link
Owner

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few small tweaks needed + better testing.

tests/test_dataset.py Outdated Show resolved Hide resolved
phylokit/dataset.py Outdated Show resolved Hide resolved
Copy link
Owner

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeromekelleher jeromekelleher merged commit 6d6f559 into jeromekelleher:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants