-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to save and open dataset #38
Add functions to save and open dataset #38
Conversation
Billyzhang1229
commented
Sep 21, 2022
•
edited
Loading
edited
- Add save_dataset/load_dataset to support on-disk Zarr storage #37
Pull Request Test Coverage Report for Build 3099046953Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Looks like a bunch of unrelated parsimony stuff included here. Simplest thing would be to rebase this PR on upstream/main and to drop all but the last commit. (But make sure you have a backup of these commits on another branch!) |
9720387
to
a4a2ab6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few small tweaks needed + better testing.
a4a2ab6
to
05bd0d0
Compare
05bd0d0
to
8a55a5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!