Fix unsetting upstream when it doesn't exist

jesseduffield · Nov 4, 2023 · d145e81 · d145e81
1 parent e0fc8fe
commit d145e81
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/pkg/gui/controllers/branches_controller.go b/pkg/gui/controllers/branches_controller.go
@@ -257,9 +257,12 @@ func (self *BranchesController) viewUpstreamOptions(selectedBranch *models.Branc
 		Key:     'r',
 	}
 
+	if !selectedBranch.IsTrackingRemote() {
+		unsetUpstreamItem.DisabledReason = self.c.Tr.UpstreamNotSetError
+	}
+
 	if !selectedBranch.RemoteBranchStoredLocally() {
 		viewDivergenceItem.DisabledReason = self.c.Tr.UpstreamNotSetError
-		unsetUpstreamItem.DisabledReason = self.c.Tr.UpstreamNotSetError
 		upstreamResetItem.DisabledReason = self.c.Tr.UpstreamNotSetError
 		upstreamRebaseItem.DisabledReason = self.c.Tr.UpstreamNotSetError
 	}

diff --git a/pkg/integration/tests/branch/unset_upstream.go b/pkg/integration/tests/branch/unset_upstream.go
@@ -51,13 +51,9 @@ var UnsetUpstream = NewIntegrationTest(NewIntegrationTestArgs{
 					Title(Equals("Upstream options")).
 					Select(Contains("Unset upstream of selected branch")).
 					Confirm()
-				t.ExpectPopup().Alert().
-					Title(Equals("Error")).
-					Content(Equals("The selected branch has no upstream (or the upstream is not stored locally)")).
-					Cancel()
 			}).
 			SelectedLines(
-				Contains("branch_to_remove").Contains("origin branch_to_remove").Contains("upstream gone"),
+				Contains("branch_to_remove").DoesNotContain("origin branch_to_remove").DoesNotContain("upstream gone"),
 			)
 	},
 })