-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Rule Docs URL (vscode-lintlens) #87
Open
Luxcium
wants to merge
2
commits into
jfmengels:master
Choose a base branch
from
Luxcium:master_latest_02
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Squash: adding prettier to conform with original style (#2) * Squash changes: Missing Rule Docs URL (#1) * Bump lodash.mergewith from 4.6.1 to 4.6.2 Bumps [lodash.mergewith](https://github.com/lodash/lodash) from 4.6.1 to 4.6.2. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/commits) Signed-off-by: dependabot[bot] <[email protected]> * Bump mixin-deep from 1.3.1 to 1.3.2 Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * Bump lodash from 4.17.10 to 4.17.13 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.10...4.17.13) Signed-off-by: dependabot[bot] <[email protected]> * Bump lodash.merge from 4.6.1 to 4.6.2 Bumps [lodash.merge](https://github.com/lodash/lodash) from 4.6.1 to 4.6.2. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/commits) Signed-off-by: dependabot[bot] <[email protected]> * Bump eslint-utils from 1.3.1 to 1.4.3 Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.3.1...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * Bump js-yaml from 3.12.0 to 3.13.1 Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.0 to 3.13.1. - [Release notes](https://github.com/nodeca/js-yaml/releases) - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.12.0...3.13.1) Signed-off-by: dependabot[bot] <[email protected]> * Bump esm from 3.0.82 to 3.2.25 Bumps [esm](https://github.com/standard-things/esm) from 3.0.82 to 3.2.25. - [Release notes](https://github.com/standard-things/esm/releases) - [Commits](standard-things/esm@3.0.82...3.2.25) Signed-off-by: dependabot[bot] <[email protected]> * Bump acorn from 5.7.2 to 5.7.4 Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.2 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.2...5.7.4) Signed-off-by: dependabot[bot] <[email protected]> * fix(docs): missing rule docs URL Your ESLint plugin has not included a URL for a rule ESLint v4.15.0 added an official location for rules to store a URL to their documentation in the rule metadata in eslint/eslint#9788. This adds the URL to all the existing rules so anything consuming them can know where their documentation is without having to resort to external packages to guess. If your plugin hasn't included this metadata, its possible you have an older version that needs to be updated. https://github.com/ghmcadams/vscode-lintlens/wiki/Missing-Rule-Docs-URL Signed-off-by: Benjamin Vincent <[email protected]> * fix: singleQuote Signed-off-by: Benjamin Vincent <[email protected]> * bump: version minor &add prettier rule singleQuote Signed-off-by: Benjamin Vincent <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * prettier: fixing back my mistakes ... Signed-off-by: Benjamin Vincent <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: version to 2.2.0 from 2.2 * fix: remove comment rules/consistent-compose.js:38:7 229 ✖ 38:7 Comments should not begin with a lowercase character capitalized-comments 230 * fix: linting issues rules/no-submodule-destructuring.js:7:37 292 ✖ 7:37 There should be no space after {. object-curly-spacing 293 ✖ 7:63 There should be no space before }. object-curly-spacing 294 ✖ 8:35 There should be no space after {. object-curly-spacing 295 ✖ 8:59 There should be no space before }. object-curly-spacing 296 ✖ 47:7 Comments should not begin with a lowercase character capitalized-comments * fix: lint issues rules/prefer-get.js:21:47 306 ✖ 21:47 There should be no space after {. object-curly-spacing 307 ✖ 21:58 There should be no space before }. object-curly-spacing 308 ✖ 31:24 There should be no space after {. object-curly-spacing 309 ✖ 31:78 There should be no space before }. object-curly-spacing 310 ✖ 61:7 Comments should not begin with a lowercase character capitalized-comments * fix: lint issues 297 298 rules/no-chain.js:11:9 299 ✖ 11:9 There should be no space after {. object-curly-spacing 300 ✖ 11:19 There should be no space before }. object-curly-spacing 301 ✖ 15:13 There should be no space after {. object-curly-spacing 302 ✖ 15:22 There should be no space before }. object-curly-spacing 303 ✖ 30:7 Comments should not begin with a lowercase character capitalized-comments 304 305 * fix: lint issue 284 rules/no-extraneous-partials.js:6:53 285 ✖ 6:53 There should be no space after {. object-curly-spacing 286 ✖ 6:77 There should be no space before }. object-curly-spacing 287 ✖ 13:13 There should be no space after {. object-curly-spacing 288 ✖ 13:22 There should be no space before }. object-curly-spacing 289 ✖ 29:7 Comments should not begin with a lowercase character capitalized-comments 290 291 * fix: lint issues rules/prefer-identity.js:43:30 280 ✖ 43:30 There should be no space after {. object-curly-spacing 281 ✖ 43:54 There should be no space before }. object-curly-spacing 282 ✖ 45:7 Comments should not begin with a lowercase character capitalized-comments * fix: lint issues rules/prefer-constant.js:61:30 275 ✖ 61:30 There should be no space after {. object-curly-spacing 276 ✖ 61:54 There should be no space before }. object-curly-spacing 277 ✖ 63:7 Comments should not begin with a lowercase character capitalized-comments * fix: lint issue rules/use-fp.js:36:7 226 ✖ 36:7 Comments should not begin with a lowercase character capitalized-comments * fix: lint issues 13 more files 227 231 rules/consistent-name.js:64:7 232 ✖ 64:7 Comments should not begin with a lowercase character capitalized-comments 233 234 rules/prefer-flat-map.js:62:7 235 ✖ 62:7 Comments should not begin with a lowercase character capitalized-comments 236 237 rules/no-argumentless-calls.js:31:7 238 ✖ 31:7 Comments should not begin with a lowercase character capitalized-comments 239 240 rules/prefer-composition-grouping.js:56:7 241 ✖ 56:7 Comments should not begin with a lowercase character capitalized-comments 242 243 rules/prefer-compact.js:36:7 244 ✖ 36:7 Comments should not begin with a lowercase character capitalized-comments 245 246 rules/no-unused-result.js:40:7 247 ✖ 40:7 Comments should not begin with a lowercase character capitalized-comments 248 249 rules/no-extraneous-args.js:48:7 250 ✖ 48:7 Comments should not begin with a lowercase character capitalized-comments 251 252 rules/no-single-composition.js:37:7 253 ✖ 37:7 Comments should not begin with a lowercase character capitalized-comments 254 255 rules/preferred-alias.js:73:7 256 ✖ 73:7 Comments should not begin with a lowercase character capitalized-comments 257 258 rules/no-extraneous-iteratee-args.js:43:7 259 ✖ 43:7 Comments should not begin with a lowercase character capitalized-comments 260 261 rules/no-partial-of-curried.js:30:7 262 ✖ 30:7 Comments should not begin with a lowercase character capitalized-comments 263 264 rules/no-for-each.js:8:13 265 ✖ 8:13 There should be no space after {. object-curly-spacing 266 ✖ 8:31 There should be no space before }. object-curly-spacing 267 ✖ 50:7 Comments should not begin with a lowercase character capitalized-comments 268 269 rules/no-extraneous-function-wrapping.js:24:11 270 ✖ 24:11 There should be no space after {. object-curly-spacing 271 ✖ 24:18 There should be no space before }. object-curly-spacing 272 ✖ 88:7 Comments should not begin with a lowercase character capitalized-comments 273 274 278 279 283 Signed-off-by: Benjamin Vincent <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Major Node.js versions enter Current release status for six months, which gives library authors time to add support for them. After six months, odd-numbered releases (9, 11, etc.) become unsupported, and even- numbered releases (10, 12, etc.) move to Active LTS status and are ready for general use. LTS release status is "long-term support", which typically guarantees that critical bugs will be fixed for a total of 30 months. Production applications should only use Active LTS or Maintenance LTS releases. Signed-off-by: Benjamin Vincent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squash: adding prettier to conform with original style (
consistent-name
rule #2)Squash changes: Missing Rule Docs URL (Rule
no-incorrect-submodule
#1)Bump lodash.mergewith from 4.6.1 to 4.6.2
Bumps lodash.mergewith from 4.6.1 to 4.6.2.
Signed-off-by: dependabot[bot] [email protected]
Bumps mixin-deep from 1.3.1 to 1.3.2.
Signed-off-by: dependabot[bot] [email protected]
Bumps lodash from 4.17.10 to 4.17.13.
Signed-off-by: dependabot[bot] [email protected]
Bumps lodash.merge from 4.6.1 to 4.6.2.
Signed-off-by: dependabot[bot] [email protected]
Bumps eslint-utils from 1.3.1 to 1.4.3.
Signed-off-by: dependabot[bot] [email protected]
Bumps js-yaml from 3.12.0 to 3.13.1.
Signed-off-by: dependabot[bot] [email protected]
Bumps esm from 3.0.82 to 3.2.25.
Signed-off-by: dependabot[bot] [email protected]
Bumps acorn from 5.7.2 to 5.7.4.
Signed-off-by: dependabot[bot] [email protected]
Your ESLint plugin has not included a URL for a rule
ESLint v4.15.0 added an official location for rules to store
a URL to their documentation in the rule metadata in
eslint/eslint#9788.
This adds the URL to all the existing rules so anything
consuming them can know where their documentation is
without having to resort to external packages to guess. If
your plugin hasn't included this metadata, its possible
you have an older version that needs to be updated.
https://github.com/ghmcadams/vscode-lintlens/wiki/Missing-Rule-Docs-URL
Signed-off-by: Benjamin Vincent [email protected]
Signed-off-by: Benjamin Vincent [email protected]
Signed-off-by: Benjamin Vincent [email protected]
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Benjamin Vincent [email protected]
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fix: version to 2.2.0 from 2.2
fix: remove comment
rules/consistent-compose.js:38:7
229
✖ 38:7 Comments should not begin with a lowercase character capitalized-comments
230
fix: linting issues
rules/no-submodule-destructuring.js:7:37
292
✖ 7:37 There should be no space after {. object-curly-spacing
293
✖ 7:63 There should be no space before }. object-curly-spacing
294
✖ 8:35 There should be no space after {. object-curly-spacing
295
✖ 8:59 There should be no space before }. object-curly-spacing
296
✖ 47:7 Comments should not begin with a lowercase character capitalized-comments
fix: lint issues
rules/prefer-get.js:21:47
306
✖ 21:47 There should be no space after {. object-curly-spacing
307
✖ 21:58 There should be no space before }. object-curly-spacing
308
✖ 31:24 There should be no space after {. object-curly-spacing
309
✖ 31:78 There should be no space before }. object-curly-spacing
310
✖ 61:7 Comments should not begin with a lowercase character capitalized-comments
fix: lint issues
297
298
rules/no-chain.js:11:9
299
✖ 11:9 There should be no space after {. object-curly-spacing
300
✖ 11:19 There should be no space before }. object-curly-spacing
301
✖ 15:13 There should be no space after {. object-curly-spacing
302
✖ 15:22 There should be no space before }. object-curly-spacing
303
✖ 30:7 Comments should not begin with a lowercase character capitalized-comments
304
305
284
rules/no-extraneous-partials.js:6:53
285
✖ 6:53 There should be no space after {. object-curly-spacing
286
✖ 6:77 There should be no space before }. object-curly-spacing
287
✖ 13:13 There should be no space after {. object-curly-spacing
288
✖ 13:22 There should be no space before }. object-curly-spacing
289
✖ 29:7 Comments should not begin with a lowercase character capitalized-comments
290
291
rules/prefer-identity.js:43:30
280
✖ 43:30 There should be no space after {. object-curly-spacing
281
✖ 43:54 There should be no space before }. object-curly-spacing
282
✖ 45:7 Comments should not begin with a lowercase character capitalized-comments
rules/prefer-constant.js:61:30
275
✖ 61:30 There should be no space after {. object-curly-spacing
276
✖ 61:54 There should be no space before }. object-curly-spacing
277
✖ 63:7 Comments should not begin with a lowercase character capitalized-comments
fix: lint issue
rules/use-fp.js:36:7
226
✖ 36:7 Comments should not begin with a lowercase character capitalized-comments
fix: lint issues 13 more files
227
231
rules/consistent-name.js:64:7
232
✖ 64:7 Comments should not begin with a lowercase character capitalized-comments
233
234
rules/prefer-flat-map.js:62:7
235
✖ 62:7 Comments should not begin with a lowercase character capitalized-comments
236
237
rules/no-argumentless-calls.js:31:7
238
✖ 31:7 Comments should not begin with a lowercase character capitalized-comments
239
240
rules/prefer-composition-grouping.js:56:7
241
✖ 56:7 Comments should not begin with a lowercase character capitalized-comments
242
243
rules/prefer-compact.js:36:7
244
✖ 36:7 Comments should not begin with a lowercase character capitalized-comments
245
246
rules/no-unused-result.js:40:7
247
✖ 40:7 Comments should not begin with a lowercase character capitalized-comments
248
249
rules/no-extraneous-args.js:48:7
250
✖ 48:7 Comments should not begin with a lowercase character capitalized-comments
251
252
rules/no-single-composition.js:37:7
253
✖ 37:7 Comments should not begin with a lowercase character capitalized-comments
254
255
rules/preferred-alias.js:73:7
256
✖ 73:7 Comments should not begin with a lowercase character capitalized-comments
257
258
rules/no-extraneous-iteratee-args.js:43:7
259
✖ 43:7 Comments should not begin with a lowercase character capitalized-comments
260
261
rules/no-partial-of-curried.js:30:7
262
✖ 30:7 Comments should not begin with a lowercase character capitalized-comments
263
264
rules/no-for-each.js:8:13
265
✖ 8:13 There should be no space after {. object-curly-spacing
266
✖ 8:31 There should be no space before }. object-curly-spacing
267
✖ 50:7 Comments should not begin with a lowercase character capitalized-comments
268
269
rules/no-extraneous-function-wrapping.js:24:11
270
✖ 24:11 There should be no space after {. object-curly-spacing
271
✖ 24:18 There should be no space before }. object-curly-spacing
272
✖ 88:7 Comments should not begin with a lowercase character capitalized-comments
273
274
278
279
283
Signed-off-by: Benjamin Vincent [email protected]
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bump acorn from 5.7.2 to 5.7.4 dependencies
closes #84 opened on 14 Mar by dependabot bot
Bump esm from 3.0.82 to 3.2.25 dependencies
closes #82 opened on 7 Nov 2019 by dependabot bot
Bump js-yaml from 3.12.0 to 3.13.1 dependencies
closes #81 opened on 7 Nov 2019 by dependabot bot
Bump eslint-utils from 1.3.1 to 1.4.3 dependencies
closes #80 opened on 7 Nov 2019 by dependabot bot
Bump lodash.merge from 4.6.1 to 4.6.2 dependencies
closes #79 opened on 7 Nov 2019 by dependabot bot
Bump mixin-deep from 1.3.1 to 1.3.2 dependencies
closes #78 opened on 7 Nov 2019 by dependabot bot
Bump lodash from 4.17.10 to 4.17.13 dependencies
closes #77 opened on 7 Nov 2019 by dependabot bot
Bump lodash.mergewith from 4.6.1 to 4.6.2 dependencies
closes #76 opened on 7 Nov 2019 by dependabot bot