Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This should resolve #42. I noticed a similar issue and discovered th… #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions exploitable/lib/analyzers/x86.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def isErrorWhileExecutingFromStack(self):
if self.isBenign():
return False
sect = self.target.procmaps().findByAddr(self.target.pc())
if sect and sect.name == "[stack]": # maybe check threadstacks too?
if sect and "[stack]" in sect.name: # maybe check threadstacks too?
return True
return False

Expand Down Expand Up @@ -139,7 +139,7 @@ def isPossibleStackCorruption(self):
return True

pm = self.target.procmaps().findByAddr(self.target.stack_pointer())
if not pm or pm.name != "[stack]":
if not pm or "[stack]" not in pm.name:
return True

return False
Expand Down Expand Up @@ -179,7 +179,7 @@ def isStackOverflow(self):

# verify the stack pointer is outside the default stack region
pm = self.target.procmaps().findByAddr(self.target.stack_pointer())
if pm and pm.name == "[stack]":
if pm and "[stack]" in pm.name:
return False

return True
Expand Down