Use longer wake allowance #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 5, 2025
The TeslaFi API supports adding a `wake=N` argument that instructs TeslaFi to wait for up to `N` seconds for the car to wake up before sending the requested command. In my testing, wake=10 was sufficient to allow the car to wake up, but that testing was performed at home on wifi. Issues #39 and #47 report that 10 seconds may not be enough time to wake the car fully, but 30 seconds appears to be more reliable. If the car is already awake when a command is being sent, then the argument will have no effect. So this should be a safe change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TeslaFi API supports adding a
wake=Nargument that instructs TeslaFi to wait for up toNseconds for the car to wake up before sending the requested command. In my testing, wake=10 was sufficient to allow the car to wake up, but that testing was performed at home on wifi.#39 and #47 report that 10 seconds may not be enough time to wake the car fully, but 30 seconds appears to be more reliable.
If the car is already awake when a command is being sent, then the argument will have no effect. So this should be a safe change.