Fix error response detection #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for `is dict` we were trying to use previously was wrong, and would have needed to be `type(data) is dict`. But that is not the recommended way to check for a dictionary anyway, so this fixes it to use `isinstance()` instead. This also adds a check for a different way that TeslaFi can report an error: specifically, if the API key is not recognized, the response is completely different compared to when it is recognized but the API has been disabled; or the particular feature of the API is not enabled (such as unlocking). We were already checking for the latter, but not the former, so the error in this case is confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for
is dictwe were trying to use previously was wrong, and would have needed to betype(data) is dict. But that is not the recommended way to check for a dictionary anyway, so this fixes it to useisinstance()instead.This also adds a check for a different way that TeslaFi can report an error: specifically, if the API key is not recognized, the response is completely different compared to when it is recognized but the API has been disabled; or the particular feature of the API is not enabled (such as unlocking). We were already checking for the latter, but not the former, so the error in this case is confusing.