Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CEDAR and ARCHS4 and overhaul and simplify code base #28

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Jan 23, 2024

This pull request:

  • removes the dependency on alldataFilesEditor.Rmd to add or edit entries in the tables (this file is now deprecated/unnecessary -- will remove in a later push)
  • ports over previously added or edited entries to their respective files (e.g., a resource ISIC Archive now in resourceTable.Rmd) and CaPTk, an imaging tool, now in imagingTable.Rmd)
  • adds CEDAR and ARCHS4 as ITCR funded resources in resourceTable.Rmd
  • corrected CGC entry within multiTable.Rmd. Two of its Data Provided were not comma separated and therefore were not linked in the tables. Now they should be comma separated and ICGC linked.
  • added a script with two functions to handle formatting of tables (scripts/format-tables.R). Sourced this file and called its functions within each sub-table Rmarkdown (clinicalTable.Rmd, imagingTable.Rmd, multiTable.Rmd, omicsTable.Rmd, and resourceTable.Rmd).
  • no longer requires .csv files to be written for each formatted/modified sub-table. The variables are now inherited within allTables.Rmd.

Further work will improve documentation to explain what is happening and what steps should be followed in order to add or edit additional tools/resources. There may also be further reduction of I/O, regarding the resource identifier file, but not sure about this.

Copy link

github-actions bot commented Jan 23, 2024

No spelling errors! 🎉
Comment updated at 2024-02-08 with changes from 6f77e44

Copy link

github-actions bot commented Jan 23, 2024

No broken URLs detected! 🎉
Comment updated at 2024-02-08 with changes from 6f77e44

@kweav
Copy link
Contributor Author

kweav commented Jan 25, 2024

added PCDC and documentation. No further reduction in I/O

Copy link

github-actions bot commented Jan 25, 2024

Re-rendered previews from the latest commit: See preview of website here

Updated at 2024-02-08 with changes from 6f77e44

@kweav kweav marked this pull request as ready for review January 25, 2024 23:30
@kweav kweav requested a review from carriewright11 January 25, 2024 23:30
Copy link
Member

@carriewright11 carriewright11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just have some documentation minor edits. But I was wondering if you were saying in the readme that the table with all tools doesn't show data? "The rows of these tables are joined together to form the all tools table (resources are not included in this)" In the current version it seems to - was this a change you made? https://jhudatascience.org/ITCR_Tables/allTables.html

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
kweav and others added 3 commits February 7, 2024 22:07
Co-authored-by: Carrie Wright <[email protected]>
Co-authored-by: Carrie Wright <[email protected]>
Co-authored-by: Carrie Wright <[email protected]>
@carriewright11
Copy link
Member

I think once we add "data" to the relevant file names this should be good to go :) (unless you did already and I missed that)

@kweav kweav merged commit 3eb561e into main Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants