-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CEDAR and ARCHS4 and overhaul and simplify code base #28
Conversation
No spelling errors! 🎉 |
No broken URLs detected! 🎉 |
added PCDC and documentation. No further reduction in I/O |
Re-rendered previews from the latest commit: See preview of website here Updated at 2024-02-08 with changes from 6f77e44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just have some documentation minor edits. But I was wondering if you were saying in the readme that the table with all tools doesn't show data? "The rows of these tables are joined together to form the all tools table (resources are not included in this)" In the current version it seems to - was this a change you made? https://jhudatascience.org/ITCR_Tables/allTables.html
Co-authored-by: Carrie Wright <[email protected]>
Co-authored-by: Carrie Wright <[email protected]>
Co-authored-by: Carrie Wright <[email protected]>
I think once we add "data" to the relevant file names this should be good to go :) (unless you did already and I missed that) |
This pull request:
alldataFilesEditor.Rmd
to add or edit entries in the tables (this file is now deprecated/unnecessary -- will remove in a later push)resourceTable.Rmd
) and CaPTk, an imaging tool, now inimagingTable.Rmd
)resourceTable.Rmd
multiTable.Rmd
. Two of itsData Provided
were not comma separated and therefore were not linked in the tables. Now they should be comma separated and ICGC linked.scripts/format-tables.R
). Sourced this file and called its functions within each sub-table Rmarkdown (clinicalTable.Rmd
,imagingTable.Rmd
,multiTable.Rmd
,omicsTable.Rmd
, andresourceTable.Rmd
)..csv
files to be written for each formatted/modified sub-table. The variables are now inherited withinallTables.Rmd
.Further work will improve documentation to explain what is happening and what steps should be followed in order to add or edit additional tools/resources. There may also be further reduction of I/O, regarding the resource identifier file, but not sure about this.