Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redo logger abstraction and example program to test multi-threaded trx #147

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jiangzhe
Copy link
Owner

@jiangzhe jiangzhe commented Dec 16, 2024

Current group commit is similar to the implementation of MySQL, without multiple stages.
But it's not performant in multi-threaded environment.
The test of example program shows, when redo log disabled, the group commit encounters a large drop when there are more than 4 threads, contending the global mutex...
I'd like to try an optimization to use ringbuffer directly to aggregate logs to eliminate the lock in group commit.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 17.14286% with 29 lines in your changes missing coverage. Please review.

Project coverage is 72.59%. Comparing base (268e366) to head (c495693).

Files with missing lines Patch % Lines
doradb-storage/examples/multi_threaded_trx.rs 0.00% 17 Missing ⚠️
doradb-storage/src/trx/sys.rs 33.33% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   72.68%   72.59%   -0.10%     
==========================================
  Files         130      130              
  Lines       18008    18025      +17     
==========================================
- Hits        13089    13085       -4     
- Misses       4919     4940      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiangzhe jiangzhe merged commit 15dc753 into main Dec 16, 2024
1 check passed
@jiangzhe jiangzhe deleted the redo-logger branch December 16, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants