fire: Add early returns #1180
CohenArthur
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
build_test_fmt.yml
on: pull_request
coding-style
10s
build-without-warnings
42s
tests
1m 36s
Annotations
7 errors and 6 warnings
|
called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`:
fire/src/lib.rs#L267
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
--> fire/src/lib.rs:267:9
|
267 | // to_run.map(|block| {
268 | || self.fire_node_ref(block);
269 | || self.gc.transfer(block, node.origin)
270 | || });
| ||__________^- help: try: `if let Some(block) = to_run { ... }`
| |__________|
|
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
= note: `-D clippy::option-map-unit-fn` implied by `-D warnings`
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
fire/src/lib.rs#L241
error: this expression creates a reference which is immediately dereferenced by the compiler
--> fire/src/lib.rs:241:24
|
241 | self.fire_node(&self.access(node_ref))
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.access(node_ref)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
fire/src/lib.rs#L182
error: this expression creates a reference which is immediately dereferenced by the compiler
--> fire/src/lib.rs:182:55
|
182 | let result = self.perform_extern_call(&def, args);
| ^^^^ help: change this to: `def`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
fire/src/lib.rs#L175
error: this expression creates a reference which is immediately dereferenced by the compiler
--> fire/src/lib.rs:175:28
|
175 | self.fire_node(&self.access(arg));
| ^^^^^^^^^^^^^^^^^ help: change this to: `self.access(arg)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
fire/src/lib.rs#L141
error: this expression creates a reference which is immediately dereferenced by the compiler
--> fire/src/lib.rs:141:28
|
141 | self.fire_node(&self.access(node));
| ^^^^^^^^^^^^^^^^^^ help: change this to: `self.access(node)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
|
|
build-without-warnings
Process completed with exit code 101.
|
|
tests
Process completed with exit code 101.
|
|
coding-style
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
tests-check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build-without-warnings
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
functional_tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|