fire: Add early returns #1181
CohenArthur
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
build_test_fmt.yml
on: pull_request
coding-style
8s
build-without-warnings
28s
tests
1m 24s
Annotations
6 errors and 6 warnings
|
this expression creates a reference which is immediately dereferenced by the compiler:
fire/src/lib.rs#L313
error: this expression creates a reference which is immediately dereferenced by the compiler
--> fire/src/lib.rs:313:24
|
313 | self.fire_node(&self.access(node_ref))
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.access(node_ref)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
fire/src/lib.rs#L216
error: this expression creates a reference which is immediately dereferenced by the compiler
--> fire/src/lib.rs:216:55
|
216 | let result = self.perform_extern_call(&def, args);
| ^^^^ help: change this to: `def`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
fire/src/lib.rs#L207
error: this expression creates a reference which is immediately dereferenced by the compiler
--> fire/src/lib.rs:207:28
|
207 | self.fire_node(&self.access(arg))?;
| ^^^^^^^^^^^^^^^^^ help: change this to: `self.access(arg)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
fire/src/lib.rs#L159
error: this expression creates a reference which is immediately dereferenced by the compiler
--> fire/src/lib.rs:159:49
|
159 | .try_for_each(|node| self.fire_node(&self.access(node)))?;
| ^^^^^^^^^^^^^^^^^^ help: change this to: `self.access(node)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
|
|
variants `Break` and `Continue` are never constructed:
fire/src/lib.rs#L38
error: variants `Break` and `Continue` are never constructed
--> fire/src/lib.rs:38:5
|
36 | enum EarlyExit {
| --------- variants in this enum
37 | Return(OriginIdx),
38 | Break(OriginIdx),
| ^^^^^
39 | Continue(OriginIdx),
| ^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
|
|
build-without-warnings
Process completed with exit code 101.
|
|
coding-style
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
tests-check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build-without-warnings
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
functional_tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|