Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple Fir executor #617

Merged
merged 17 commits into from
Oct 19, 2023
Merged

Add simple Fir executor #617

merged 17 commits into from
Oct 19, 2023

Conversation

CohenArthur
Copy link
Member

@CohenArthur CohenArthur commented Apr 23, 2023 •
edited
Loading

  • fire: Add extremely basic interpretation engine
  • fire: Start performing calls to builtin functions
  • fire: Add proper tree-like interpretation
  • fire: wip: Add more comments regarding execution

Fixes #615
Fixes #618

@CohenArthur CohenArthur force-pushed the basic-executor branch 2 times, most recently from 0a6cecc to ed4772c Compare May 14, 2023 19:16
@CohenArthur
Copy link
Member Author

CohenArthur commented May 14, 2023 •
edited
Loading

Once the FIXMEs are corrected, the executor will be in pretty good shape for more additions

  • How do we deal with the fact that we're acting on a Flat representation?
  • Is the [Fir] stable? Can we just access the last node as the entry point to the [Fir]? then it makes everything super easy actually
  • Add bindings here between the function's variables and the arguments given to the call
  • Decide on move/copy semantics
  • Remove unwraps
  • Add base for documentation

@CohenArthur CohenArthur force-pushed the basic-executor branch 2 times, most recently from 5290da2 to c43c79a Compare October 15, 2023 15:34
@CohenArthur
Copy link
Member Author

the Fire can now execute calls, as well as nested calls. this PR is already big enough, so work on the executor will continue in different pull requests. needs #620 before merging

@CohenArthur CohenArthur marked this pull request as ready for review October 15, 2023 22:36
@CohenArthur
Copy link
Member Author

Adding some documentation and cleaning up the code and this will get merged

CohenArthur and others added 16 commits October 16, 2023 02:30
@CohenArthur
fire: Add extremely basic interpretation engine
9252260
@CohenArthur
fire: Start performing calls to builtin functions
cf6c084
@CohenArthur
fire: Add proper tree-like interpretation
ffe84de
@CohenArthur
fire: wip: Add more comments regarding execution
0972bda
@CohenArthur
fire: wip: cleanup
23fa4b0
@CohenArthur
fire: Cleanup API and inner functions
02bf22c
@CohenArthur
fire: Start adding tests
e554628
@CohenArthur
ast: Allow returning values from program's entry point
6ad6f25
@CohenArthur
fire: Add handling for Blocks and Returns
61c9bb7
@CohenArthur
fire: Fix call logic and transfer of return value
ac3d6e4
@CohenArthur
nr: Add test for #615
c438311 
Fixes #615
@CohenArthur
typecheck: Add test for #618
f6ca55c 
Fixes #618
@CohenArthur
fire: Add documentation and improve fire::Instance
312c13d
@CohenArthur
typecheck: Do not error out when typechecking ext functions
d9f5e75
@CohenArthur
interpreter: Convert returned instance into exit code
f6fd839
@CohenArthur
fire: Add documentation and clean up implementation
99a86d8
@CohenArthur CohenArthur merged commit d276e23 into master Oct 19, 2023
@CohenArthur CohenArthur deleted the basic-executor branch October 19, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid function parameter type resolution Name resolution does not scope bindings properly
1 participant
@CohenArthur