Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typecheck and execute arithmetic ops properly #634

Merged
merged 13 commits into from
Nov 10, 2023
Merged

Typecheck and execute arithmetic ops properly #634

merged 13 commits into from
Nov 10, 2023

Conversation

CohenArthur
Copy link
Member

@CohenArthur CohenArthur commented Oct 29, 2023 •
edited
Loading

Needs #631 and #630

@CohenArthur CohenArthur force-pushed the typecheck-arithmetic-ops branch from 77a57cf to a012e4b Compare October 29, 2023 14:31
@CohenArthur CohenArthur mentioned this pull request Oct 29, 2023
Closed
@CohenArthur CohenArthur changed the title Typecheck arithmetic ops properly Typecheck and execute arithmetic ops properly Oct 29, 2023
@CohenArthur CohenArthur force-pushed the typecheck-arithmetic-ops branch from a012e4b to 43d97cb Compare October 29, 2023 15:41
@CohenArthur
Copy link
Member Author

this needs to modify flatten as well to reuse builtins::ADD instead of creating calls to "+" directly

@CohenArthur CohenArthur force-pushed the typecheck-arithmetic-ops branch from 43d97cb to b04e2c0 Compare November 10, 2023 11:32
@CohenArthur CohenArthur merged commit 60fcbbb into master Nov 10, 2023
9 checks passed
@CohenArthur CohenArthur deleted the typecheck-arithmetic-ops branch November 10, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CohenArthur