New-feature-branch : Successfully pushed the full AES-256 and PBKDF2 encryption enhancements #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, looks like things are messed up as you kight have synced the fork before raising this PR. I can see 517 file changes, and its next to impossible to find your actual changes in such case.. I'd recommend you to delete this branch, and redo your changes in a new up-to-dated branch. This way you'll not face any merge conflicts and it'll be easy for us to review your changes @Ishratnoori. I appreciate your active cooperation till now ;D |
|
|
|
|
Yup, you should be creating a pull request only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jindalpriyanshu101 and @jinx-vi-0,
I have successfully pushed the full AES-256 and PBKDF2 encryption enhancements in the new-feature-branch. You can find the changes in the pull request I created.
Thank you for your guidance throughout this process!
Best regards,
Ishrat noori :)