-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better and responsive UI for the Homepage. #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
hey @Ayush215mb , There is some issue with your PR. Every time a new password is generated, the page reloads, which did not happen previously. |
I haven't changed any function syntax but still I will look into it. |
@jinx-vi-0 check it now, I have added event.preventdefault in the generate password function which was missing before. |
@jinx-vi-0 also don't forget to add the labels here, in the hacktober website this PR is still showing not participating so please add it before merging. |
hey @Ayush215mb , Your pull request had several issues. I'm removing the changes for now. If you want to revisit this, please ensure that all the issues are fixed. |
@jinx-vi-0 can you tell me the issues?? |
Please review the recently closed issue. Most of the mentioned issues arose after your pull request. |
I have completed the issue assigned to me #18, Please review it and accept it after adding all the labels.
Below are the Images of new UI, the footer is not visible in the ss but they are down below.