Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better and responsive UI for the Homepage. #44

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

Ayush215mb
Copy link
Contributor

I have completed the issue assigned to me #18, Please review it and accept it after adding all the labels.
Below are the Images of new UI, the footer is not visible in the ss but they are down below.
image
image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@jinx-vi-0
Copy link
Owner

jinx-vi-0 commented Oct 6, 2024

hey @Ayush215mb , There is some issue with your PR. Every time a new password is generated, the page reloads, which did not happen previously.

@Ayush215mb
Copy link
Contributor Author

I haven't changed any function syntax but still I will look into it.

@Ayush215mb
Copy link
Contributor Author

@jinx-vi-0 check it now, I have added event.preventdefault in the generate password function which was missing before.
Now it will not get refreshed on clicking.

@Ayush215mb
Copy link
Contributor Author

@jinx-vi-0 also don't forget to add the labels here, in the hacktober website this PR is still showing not participating so please add it before merging.
I already got my one merged PR wasted because the owner hadn't added labels so hacktober didn't count that, so please do it here before merging.

@jinx-vi-0 jinx-vi-0 added gssoc-ext GSSoC'24 Extended hacktoberfest-accepted hacktoberfest 2024 level2 gssoc: level 2 labels Oct 7, 2024
@jinx-vi-0 jinx-vi-0 added level3 gssoc: level 3 and removed level2 gssoc: level 2 labels Oct 7, 2024
@jinx-vi-0 jinx-vi-0 merged commit 19c0104 into jinx-vi-0:main Oct 7, 2024
1 check passed
@jinx-vi-0 jinx-vi-0 added level2 gssoc: level 2 and removed level3 gssoc: level 3 labels Oct 7, 2024
jinx-vi-0 added a commit that referenced this pull request Oct 7, 2024
@jinx-vi-0 jinx-vi-0 removed the level2 gssoc: level 2 label Oct 7, 2024
@jinx-vi-0
Copy link
Owner

hey @Ayush215mb , Your pull request had several issues. I'm removing the changes for now. If you want to revisit this, please ensure that all the issues are fixed.

@Ayush215mb
Copy link
Contributor Author

@jinx-vi-0 can you tell me the issues??

@jinx-vi-0
Copy link
Owner

Please review the recently closed issue. Most of the mentioned issues arose after your pull request.

@Ayush215mb
Copy link
Contributor Author

Ayush215mb commented Oct 7, 2024

issue #52 I can understand as I didn't checked that it was animation so i have added save icon instead of the previous one.
issue #51 is not true, after clicking on the generate password the generated password is written on the password field so anyone can write it .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GSSoC'24 Extended hacktoberfest-accepted hacktoberfest 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants