Feature/add changelog link #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jk1z
requested changes
Jan 2, 2020
| @@ -211,5 +213,47 @@ describe("ChangelogLib lib", () => { | |||
| "- test1 [#1](http://gitlab.example.com/my-group/my-project/merge_requests/1) ([admin](https://gitlab.example.com/admin))\n"); | |||
| }); | |||
| }); | |||
There was a problem hiding this comment.
Can we have a test case with fullChangeLogLink please?
There was a problem hiding this comment.
Added, but as mentioned in the description, I'm unable to test (or could you explain how to test?)
|
@jk1z Thanks for your review! I left some comments on it. |
|
Hi, I have made small refactoring for this and added test for the first tag. Because there should be no compare link on the first tag. cookielab@f0612cb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of the original repo links to this output example
https://github.com/github-changelog-generator/Github-Changelog-Generator/blob/master/CHANGELOG.md
That example includes a "Full Changelog" link, which basically uses the GitHub compare functionality.
This PR adds the ability to include a Full Changelog for GitLab as well.
Note to maintainer:
I've added some tests to cover this functionality, but didn't know how to run those tests. So please make sure to check those extensively.