Fix it so the value of a reference successfully is applied.

Made it so mayNotSetReferencesReason requires a value... before we forgot to supply it from another callsite. Part of #682.
jkomoros · Dec 9, 2023 · 18ef9a9 · 18ef9a9
1 parent a86dcf4
commit 18ef9a9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/actions/editor.ts b/src/actions/editor.ts
@@ -841,6 +841,8 @@ export const addReferenceToCard = (cardID : CardID, referenceType : ReferenceTyp
 		return;
 	}
 
+	if (!value) value = '';
+
 	const reason = referencesNonModifying(editingCard).mayNotSetCardReferenceReason(state, cardID, referenceType, value); 
 
 	if (reason) {

diff --git a/src/references.ts b/src/references.ts
@@ -282,7 +282,7 @@ class ReferencesAccessor {
 
 	_mayNotApplyEntryDiffItemReason(state : State, item : ReferencesEntriesDiffItem) : string {
 		if (isExpandedReferenceDelete(item)) return this.mayNotRemoveCardReferenceReason(state, item.cardID, item.referenceType);
-		return this.mayNotSetCardReferenceReason(state, item.cardID, item.referenceType);
+		return this.mayNotSetCardReferenceReason(state, item.cardID, item.referenceType, item.value);
 	}
 
 	//Removes all references for the given card.
@@ -341,7 +341,7 @@ class ReferencesAccessor {
 
 	//Returns a string describing why that reference may not be set, or '' if
 	//it's legal.
-	mayNotSetCardReferenceReason(state : State, cardID : CardID, referenceType : ReferenceType, value? : string) : string {
+	mayNotSetCardReferenceReason(state : State, cardID : CardID, referenceType : ReferenceType, value : string) : string {
 
 		if (!value) value = '';
-Original file line number
+Diff line change
@@ Expand Up @@
     		return;
     	}
+    	if (!value) value = '';
     	const reason = referencesNonModifying(editingCard).mayNotSetCardReferenceReason(state, cardID, referenceType, value);
     	if (reason) {
@@ Expand Down @@