Skip to content

Commit

Permalink
Flip the naming of TODO enable/disablement to reflect what they actua…
Browse files Browse the repository at this point in the history
…lly do in the UI.

See #689. Part of #688. Part of #174.
  • Loading branch information
jkomoros committed Mar 30, 2024
1 parent 9054973 commit 261f722
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions src/components/multi-edit-dialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ class MultiEditDialog extends connect(store)(DialogElement) {
const subtleTags = arrayDiffAsSets(unionTags, intersectionTags)[1];

//Because TODOs are a weird tri-state, we won't even try to show a intersection/union kind of thing.
//And also, yes, the naming of the items feels backwards, see #689.

return html`
<div class='${this._cardModificationPending ? 'modification-pending' : ''}'>
Expand Down Expand Up @@ -232,23 +233,23 @@ class MultiEditDialog extends connect(store)(DialogElement) {
</tag-list>
<label>Enable TODOs</label>
<tag-list
.tags=${this._todoEnablements}
.tags=${this._todoDisablements}
.editing=${true}
.tapEvents=${true}
.tagInfos=${TODO_AUTO_INFOS}
.overrideTypeName=${'Enabled'}
@tag-added=${this._handleAddTODOEnablement}
@tag-removed=${this._handleRemoveTODOEnablement}>
@tag-added=${this._handleAddTODODisablement}
@tag-removed=${this._handleRemoveTODODisablement}>
></tag-list>
<label>Disable TODOs</label>
<tag-list
.tags=${this._todoDisablements}
.tags=${this._todoEnablements}
.editing=${true}
.tapEvents=${true}
.tagInfos=${TODO_AUTO_INFOS}
.overrideTypeName=${'Disabled'}
@tag-added=${this._handleAddTODODisablement}
@tag-removed=${this._handleRemoveTODODisablement}>
@tag-added=${this._handleAddTODOEnablement}
@tag-removed=${this._handleRemoveTODOEnablement}>
></tag-list>
${Object.values(this._diff).length ? html`<h4>Changes that will be made to selected cards</h4>` : ''}
<ul class='readout'>
Expand Down

0 comments on commit 261f722

Please sign in to comment.