Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get things working in a production build and deploy #25

Closed
jkomoros opened this issue Dec 23, 2018 · 4 comments
Closed

Get things working in a production build and deploy #25

jkomoros opened this issue Dec 23, 2018 · 4 comments

Comments

@jkomoros
Copy link
Owner

Does hte build process go in a sub-folder in webapp? if so, can we get rid of webapp and just have it all in one folder?

@jkomoros
Copy link
Owner Author

jkomoros commented Dec 25, 2018

@jkomoros jkomoros changed the title Do an initial push Get things working in a production build and deploy Dec 25, 2018
@jkomoros
Copy link
Owner Author

jkomoros commented Dec 25, 2018

The styling issue. Appears to only occur when card-drawer stamps something out with repeat. But it's not because of repeat, it's because the inner content gets large enough, which triggers the min-height thing in card-drawer, which is when the issue happens. Also, in stable channel the card-drawer isn't scrolling. That appears to be the primary reason--when that's too high the card is positioned in the middle, but that's way off screen.

The problem is that the way the overall card-view is positioned on screen is not resilient--it uses a weird max-height thing. (That also means it doesn't work when the thumbnail drawer doesn't have many items in it)

  • Get the card-drawer to not overflow by th eheight of the top container
  • Ensure positioning when editing is OK

jkomoros added a commit that referenced this issue Dec 26, 2018
…stable. The card-drawer on left is off by a bit. Part of #25.
jkomoros added a commit that referenced this issue Dec 26, 2018
jkomoros added a commit that referenced this issue Dec 26, 2018
…in (I think) entirely inline with canary. Part of #25.
jkomoros added a commit that referenced this issue Dec 26, 2018
… standard way fo doing it. Makes Firefox and Safari both appear to work entirely. Part of #25.
@jkomoros
Copy link
Owner Author

jkomoros commented Dec 30, 2018

  • Switch to using the Google fonts live instead of the offline copy (verify the offline copy is included in the build anyway, part of Use firebase npm import #65)

jkomoros added a commit that referenced this issue Dec 31, 2018
… output. Also switched back to Google Fonts live imports. Part of #25
@jkomoros
Copy link
Owner Author

First deploy at 8e9c4f3 (tagged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant