Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to add context to references #682

Open
5 of 7 tasks
jkomoros opened this issue Dec 7, 2023 · 0 comments
Open
5 of 7 tasks

A way to add context to references #682

jkomoros opened this issue Dec 7, 2023 · 0 comments

Comments

@jkomoros
Copy link
Owner

jkomoros commented Dec 7, 2023

References have an ability to have text in them. By default everything but type link has an empty ''. But for some reference types it could encode useful information.

For example, a citation-person reference with non-empty text might encode the URL of a work, that doesn't make sense to factor out into a card. Or a citation to a work might include a pg 437.

This shouldn't be THAT hard to integrate.

Useful for #465

  • Add an ability to pass a value in EDITING_ADD_REFERENCE
  • Make sure that the reference diffing machinery will allow adding a text tag
  • Make it so clicking on a tag in editor will pop a prompt to add/remove text.
  • Make it so tags in editor that have extra text show a little info icon and on hover show the extra text.
  • Make it so there's some way to view the text--ideally in the card-info-panel for non-empty ones. (Does this require some bigger project to pass through some sortExtras kind of thing?)
  • The prompt to ask for a value should show different text for different reference types with suggested use
  • some kind of convention or checking for different types, a referenceTextValdiator. For example for citation it might validate that it is a comma-delimited list of page <number>.
jkomoros added a commit that referenced this issue Dec 9, 2023
jkomoros added a commit that referenced this issue Dec 9, 2023
jkomoros added a commit that referenced this issue Dec 9, 2023
jkomoros added a commit that referenced this issue Dec 9, 2023
jkomoros added a commit that referenced this issue Dec 9, 2023
Made it so mayNotSetReferencesReason requires a value... before we forgot to supply it from another
callsite.

Part of #682.
jkomoros added a commit that referenced this issue Dec 10, 2023
This is the only place that you can see the value now in the UI.

Part of #682.
jkomoros added a commit that referenced this issue Dec 10, 2023
If provided, it will render that icon.

Part of #682.
jkomoros added a commit that referenced this issue Dec 10, 2023
This helps them stand out so users can know to hover over them.

Part of #682.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant