Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up naming around auto TODO overrides #689

Open
jkomoros opened this issue Mar 30, 2024 · 0 comments
Open

Clean up naming around auto TODO overrides #689

jkomoros opened this issue Mar 30, 2024 · 0 comments

Comments

@jkomoros
Copy link
Owner

jkomoros commented Mar 30, 2024

The logic seems backwards for example we had to flip the labels in multi-edit-dialog, and in descriptionForCardDiff we have that backwards message for prioritized.

Is it possible the main naming is just backwards and then everything else has to be backwards too, in a confusing way?

Like, maybe the naming of the fields on CardDiff are backwards?

I think it's that the enablements and disablements fields in CardDiff are named backwards from what they should be, given the naming scheme for what the overrides mean on Card. And that leads to the confusing names for antyhing touching card diffs directly, like in multi-edit or descriptionForCardDiff.

jkomoros added a commit that referenced this issue Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant