Skip to content

Commit

Permalink
Row deletion bugfix, Mac icons and retina display support
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeremy Bowman committed Aug 28, 2012
1 parent 339d440 commit 65d3c4a
Show file tree
Hide file tree
Showing 14 changed files with 72 additions and 45 deletions.
13 changes: 13 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
2012-08-28 JMB Row deletion bugfix, Mac icons and retina display support

Fixed a bug where deleting a row from the row viewer would delete the
row it was first launched for, not necessarily the one it was currently
showing. Also updated a few instaces of the application icon on the Mac
that I missed when first swapping it. Enabled high-resolution text
rendering on retina displays (higher resolution icon display has to wait
for support in Qt).

Added the latest update to the French translation of the help files, and
made some changes to ensure that the updated translations of Sphinx
phrases are fully utilized in the help files.

2012-08-24 JMB Translation updates, Mac code signing

Incorporated the latest text updates from all the translators. Added a
Expand Down
2 changes: 2 additions & 0 deletions packaging/mac/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,7 @@
<string>2.1.0f1</string>
<key>LSMinimumSystemVersion</key>
<string>10.5.0</string>
<key>NSHighResolutionCapable</key>
<true/>
</dict>
</plist>
2 changes: 1 addition & 1 deletion packaging/mac/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

# By default, builds a 64-bit Intel binary. If you want to build a universal
# binary that runs on PowerPC and 32-bit Intel Macs, pass the string
# "universal" as the second parameter. You'll need to have a suitably old or
# "--universal" as the first parameter. You'll need to have a suitably old or
# hacked version of Xcode, and appropriately compiled versions of Qt and
# Metakit.

Expand Down
1 change: 1 addition & 0 deletions resources/help/translations/cs/sphinx.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

49 changes: 25 additions & 24 deletions resources/help/translations/fr/calculation_editor.po
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
# This file is distributed under the same license as the PortaBase package.
#
# Translators:
# <[email protected]>, 2012.
msgid ""
msgstr ""
"Project-Id-Version: PortaBase\n"
"Report-Msgid-Bugs-To: https://sourceforge.net/p/portabase/bugs/\n"
"POT-Creation-Date: 2012-07-27 20:40-0500\n"
"PO-Revision-Date: 2012-07-28 05:01+0000\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"PO-Revision-Date: 2012-08-27 14:20+0000\n"
"Last-Translator: danypoup <[email protected]>\n"
"Language-Team: French (http://www.transifex.com/projects/p/portabase/language/fr/)\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
Expand All @@ -20,7 +21,7 @@ msgstr ""
# 40b424d8183a49ef9d1782f44ac846e8
#: ../../calculation_editor.txt:4
msgid "Calculation editor"
msgstr ""
msgstr "Editeur de calcul"

# a6b2be0f07a84cc89925e4be520b975a
#: ../../calculation_editor.txt:6
Expand All @@ -32,7 +33,7 @@ msgid ""
" name of the column, a read-only display of the current calculation written "
"as a one-line expression, and a spin box that allows you to specify how many"
" decimal places should be shown for the calculation results."
msgstr ""
msgstr "Cette boite de dialogue vous permet de définir les colonnes qui contiendront des valeurs calculées à partir du contenu d'autres colonnes de la même ligne. Il est lancé en cliquant sur le bouton \"Modifier le calcul\" dans l'éditeur de colonne, lequel apparaît uniquement pour les colonnes de type \"Calcul\". En haut de la boite de dialogue se trouvent le nom de la colonne, l'affichage du calcul courant écrit sous la forme d'une expression sur une seule ligne et une zone de saisie qui vous permet de spécifier combien de décimales doivent être affichées pour le résultat du calcul."

# 4f5af6c77ed540b1a56ff00c62751680
#: ../../calculation_editor.txt:8
Expand All @@ -42,59 +43,59 @@ msgid ""
"represents either the value of another column, a constant value, or the "
"result of an operation. To edit the calculation, select a node from the "
"tree (if any are present) and use the buttons in the dialog:"
msgstr ""
msgstr "La plus grande partie de la boit de dialogue est remplie par un composant graphique qui montre le calcul actuel sous forme d'un arbre, similaire à un explorateur de fichiers. Chaque noeud de l'arbre représente soit la valeur d'une autre colonne, soit une valeur constante ou bien le résultat d'une opération. Pour modifier le calcul, sélectionnez un noeud de l'arbre (s'il y en a) et utilisez les boutons de la boite de dialogue :"

# 5931ce55d45b4f4cbe892e8242089f93
#: ../../calculation_editor.txt:11
msgid "**Add**"
msgstr ""
msgstr "**Ajouter**"

# 9ed33e39d0244e75b5671996435a2895
#: ../../calculation_editor.txt:11
msgid ""
"Add a new node as a child of the currently selected node; a dialog will "
"appear which allows you to select the type and value of the node."
msgstr ""
msgstr "Ajoute un nouveau noeud fils du noeud actuellement sélectionné ; une boite de dialogue s'affichera et vous permettra de sélectionner le type et la valeur du noeud."

# dd6d91ebe7ae470189743ba74d60c829
#: ../../calculation_editor.txt:14
msgid "**Edit**"
msgstr ""
msgstr "**Modifier**"

# 0602f1c6fe794888951cbdcca372d919
#: ../../calculation_editor.txt:14
msgid "Edit the selected node."
msgstr ""
msgstr "Modifier le noeud sélectionné."

# f1a545d3cbc14bb982dfb128a5b4fbce
#: ../../calculation_editor.txt:17
msgid "**Delete**"
msgstr ""
msgstr "**Supprimer**"

# 4798dbfc7c74458887dece22363185dc
#: ../../calculation_editor.txt:17
msgid "Delete the currently selected node."
msgstr ""
msgstr "Supprime le noeud actuellement sélectionné."

# 63a2b652762647af8d75869f598e4851
#: ../../calculation_editor.txt:20
msgid "**Up**"
msgstr ""
msgstr "**Monter**"

# 511b40992bc84acaa6743662bf340342
#: ../../calculation_editor.txt:20
msgid "Move the currently selected node up among its siblings."
msgstr ""
msgstr "Déplace le noeud actuellement sélectionné d'une position vers le haut."

# 835bed28447f4d5bb5baad0ce9bd0c6e
#: ../../calculation_editor.txt:23
msgid "**Down**"
msgstr ""
msgstr "**Descendre**"

# 6fd02ecf29d84e549ef0f8658c48d18e
#: ../../calculation_editor.txt:23
msgid "Move the currently selected node down among its siblings."
msgstr ""
msgstr "Déplace le noeud actuellement sélectionné d'une position vers le bas."

# 1eaec6b3f6b0465d91fa5d179338f661
#: ../../calculation_editor.txt:25
Expand All @@ -104,29 +105,29 @@ msgid ""
" their own). The buttons automatically update when a node is selected in "
"order to indicate which actions are possible; typical actions not allowed "
"are:"
msgstr ""
msgstr "Habituellement, vous désirez démarrer en ajoutant un noeud opération, tel que \"+\", et ensuite vous ajoutez ses arguments (qui peuvent eux-mêmes être des opérations avec leurs propres arguments). Les boutons se mettent à jour automatiquement quand un noeud est sélectionné afin d'indiquer quelles actions sont possible ; typiquement les actions non permises sont : "

# 095e6533d8d844cc97452bf523e9902c
#: ../../calculation_editor.txt:27
msgid ""
"Adding a child node to an operation which already has as many arguments as "
"it can use"
msgstr ""
msgstr "Ajouter un noeud enfant à une opération qui a déjà le maximum d'arguments possible"

# 639c481b219748508194e74343a115c5
#: ../../calculation_editor.txt:29
msgid "Editing an operation node; it must be deleted and replaced instead"
msgstr ""
msgstr "Modifier un noeud opération ; il doit plutôt être supprimé puis recréé"

# 3925a8a965b34204b997add6e8f8af88
#: ../../calculation_editor.txt:31
msgid "Moving a node up or down when it cannot move further in that direction"
msgstr ""
msgstr "Déplacer un noeud (vers le haut ou le bas) alors qu'il ne peut pas aller plus loin dans cette direction"

# bd869ee5d20642b4b6b7301c3e1606d5
#: ../../calculation_editor.txt:33
msgid "Some points worth noting:"
msgstr ""
msgstr "Quelques remarques complémentaires :"

# e252a40f01e24691ae0f1679a81fa050
#: ../../calculation_editor.txt:35
Expand All @@ -135,26 +136,26 @@ msgid ""
"calculations. Additionally, Date columns can be used as children of a "
"\"Days_Between\" operation, and Time columns can be used as children of "
"\"Seconds_Between\", \"Minutes_Between\", and \"Hours_Between\" operations."
msgstr ""
msgstr "Seules les colonnes de type Entier, Decimal, Séquence et Booléen peuvent être utilisées dans les calculs. De plus, les colonnes de type Date peuvent être utilisées en tant qu'enfant d'une opération \"Days_Between\" et les colonnes de type Heure peuvent être utilisées en tant qu'enfant des opérations \"Seconds_Between\", \"Minutes_Between\" et \"Hours_Between\"."

# cfc636662b1b4ebf82eb2a77a99c407c
#: ../../calculation_editor.txt:37
msgid ""
"Calculation columns cannot be used in other calculations, since this would "
"introduce a variety of complications. You can get the same effect by "
"repeating the definition of a calculation as part of another one."
msgstr ""
msgstr "Les colonnes de type Calcul ne peuvent pas être utilisées dans d'autres calculs puisque cela pourrait introduire une certaine complexité. Vous pouvez obtenir le même effet en répétant la définition du calcul dans un autre."

# 54e6c32b8e044874af417b6eaaefb9e8
#: ../../calculation_editor.txt:39
msgid ""
"Operations which haven't been given enough (or any) arguments usually return"
" zero."
msgstr ""
msgstr "Les opérations qui n'ont pas assez d'arguments retournent habituellement zéro."

# bd26c908e88f400abd83523205f2e548
#: ../../calculation_editor.txt:41
msgid ""
"If a column is renamed or deleted using the columns editor, any calculations"
" using it are automatically updated accordingly."
msgstr ""
msgstr "Si une colonne est renommée ou supprimée en utilisant l'éditeur de colonnes, tout calcul s'y référant sera mis à jour automatiquement."
29 changes: 15 additions & 14 deletions resources/help/translations/fr/image_editor.po
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
# This file is distributed under the same license as the PortaBase package.
#
# Translators:
# <[email protected]>, 2012.
msgid ""
msgstr ""
"Project-Id-Version: PortaBase\n"
"Report-Msgid-Bugs-To: https://sourceforge.net/p/portabase/bugs/\n"
"POT-Creation-Date: 2012-07-27 20:40-0500\n"
"PO-Revision-Date: 2012-07-28 05:06+0000\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"PO-Revision-Date: 2012-08-27 19:20+0000\n"
"Last-Translator: danypoup <[email protected]>\n"
"Language-Team: French (http://www.transifex.com/projects/p/portabase/language/fr/)\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
Expand All @@ -20,7 +21,7 @@ msgstr ""
# 723538d734ca4b2d9765c63c93b372b1
#: ../../image_editor.txt:4
msgid "Image editor"
msgstr ""
msgstr "Editeur d'images"

# b07976cb0dc34646ad62169e61fee86c
#: ../../image_editor.txt:6
Expand All @@ -29,57 +30,57 @@ msgid ""
"After you select an image file to import into a field in the database, this "
"dialog is shown so you can make minor changes to the copy of the image that "
"will be saved in the database. The top row contains the following controls:"
msgstr ""
msgstr "Une colonne de type Image stocke des images importées à partir de fichier au format JPEG ou PNG. Après avoir sélectionné un fichier à importer dans un champ de la base de données, cette boite de dialogue est affichée, ainsi vous pouvez apporter des modifications mineures sur la copie de l'image qui sera enregistrée dans la base de données. La ligne du haut contient les contrôles suivants :"

# a5f832b3b80d49aaa228c9263385f6bf
#: ../../image_editor.txt:9
msgid "**Width**"
msgstr ""
msgstr "**Largeur**"

# 67b32333a10b4f16bea603238410e15f
#: ../../image_editor.txt:9
msgid "The maximum allowed width of the image (in pixels)."
msgstr ""
msgstr "La largeur maximale autorisée pour l'image (en pixels)."

# 357c6c6170e54833bc385a3304afcc84
#: ../../image_editor.txt:12
msgid "**Height**"
msgstr ""
msgstr "**Hauteur**"

# 1ad8cb149206412d9e46fc224789c11d
#: ../../image_editor.txt:12
msgid "The maximum allowed height of the image (in pixels)."
msgstr ""
msgstr "La hauteur maximale autorisée pour l'image (en pixels)."

# 169e4f6d80af4780aa9f638f420cad3b
#: ../../image_editor.txt:15
msgid "**Rotate**"
msgstr ""
msgstr "**Rotation**"

# cacfabd5245349b0aa3988a64939bfc7
#: ../../image_editor.txt:15
msgid ""
"The angle by which to rotate the image (in degrees): 0, 90, 180, or 270."
msgstr ""
msgstr "L'angle de rotation de l'image (en degrés) : 0, 90, 180 ou 270."

# 009942046379418784898beb423f12ac
#: ../../image_editor.txt:18
msgid "**Refresh**"
msgstr ""
msgstr "**Actualiser**"

# c9969f62ec464f58906241b3f429f6ef
#: ../../image_editor.txt:18
msgid ""
"Apply the currently displayed settings and update the image preview "
"accordingly."
msgstr ""
msgstr "Applique la configuration d'affichage actuelle et met à jour la prévisualisation de l'image en conséquence."

# b94f400f3398469abc82d28724bdebee
#: ../../image_editor.txt:20
msgid ""
"Click \"OK\"/\"Done\" to store the image as it is shown, or cancel out of "
"the dialog to leave the field unchanged."
msgstr ""
msgstr "Cliquez sur \"OK\"/\"Fait\" pour stocker l'image telle qu'elle est affichée ou quittez la boite de dialogue en annulant pour laisser le champ non modifié."

# a2edd321360d4e79a296b5fdaa25bbf6
#: ../../image_editor.txt:22
Expand All @@ -91,4 +92,4 @@ msgid ""
"than 800 x 600 cannot be imported. These limitations will be removed in a "
"future version of PortaBase, since it is no longer being developed for the "
"Zaurus."
msgstr ""
msgstr "Parce que la mémoire était limitée sur les Zaurus, ordinateurs personnels pour lesquels PortaBase a été initialement développé, les images de très grande taille ne sont pas supportées. Les images JPEG supérieures à 6400 x 4800 pixels ne peuvent être importées et celles supérieures à 800 x 600 seront réduites à cette taille maxi. De même, les images PNG supérieures à 800 x 600 ne peuvent être importées. Ces limitations seront supprimées dans une version future de PortaBase puisque que le développement pour le Zaurus a été arrêté."
1 change: 1 addition & 0 deletions resources/help/translations/fr/sphinx.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions resources/help/translations/zh_TW/sphinx.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified resources/icons/mac/PortaBase.png
100644 → 100755
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified resources/icons/mac/document_large.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified resources/icons/mac/document_small.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion rowviewer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,8 @@ void RowViewer::deleteRow()
return;
}
}
display->deleteRow();
int rowId = view->getId(index);
display->deleteRow(rowId);
accept();
}

Expand Down
12 changes: 9 additions & 3 deletions viewdisplay.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -548,11 +548,17 @@ void ViewDisplay::viewRow()
}

/**
* Delete the record currently selected in the display table (if any).
* Delete a record that is currently shown in the display table.
*
* @param id The ID of the record to delete; if -1, the record selected in the
* display table is used
*/
void ViewDisplay::deleteRow()
void ViewDisplay::deleteRow(int id)
{
int rowId = selectedRowId();
int rowId = id;
if (rowId == -1) {
rowId = selectedRowId();
}
if (rowId != -1) {
model->deleteRow(rowId);
setEdited(true);
Expand Down
4 changes: 2 additions & 2 deletions viewdisplay.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ class ViewDisplay: public QWidget

public slots:
void addRow();
bool editRow(int rowId=-1, bool copy=false, QWidget *parent=0);
void deleteRow();
bool editRow(int id=-1, bool copy=false, QWidget *parent=0);
void deleteRow(int id=-1);
void slideshow();
void viewRow();
void showStatistics(bool allColumns=false, QWidget *parent=0);
Expand Down

0 comments on commit 65d3c4a

Please sign in to comment.