Merge pull request MapServer#6962 from rouault/FLTProcessPropertyIsNu…

…ll_always_true [Lint] FLTProcessPropertyIsNull(): remove always true comparison (due to previous check)
jmckenna · Nov 1, 2023 · 2b263e9 · 2b263e9
2 parents 23c4f71 + f5060a3
commit 2b263e9
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/mapogcfilter.cpp b/src/mapogcfilter.cpp
@@ -3150,9 +3150,8 @@ int FLTProcessPropertyIsNull(FilterEncodingNode *psFilterNode, mapObj *map,
     layerWasOpened = msLayerIsOpen(lp);
 
     /* Horrible HACK to compensate for the lack of null testing in MapServer */
-    if ((lp->connectiontype == MS_POSTGIS ||
-         (lp->connectiontype == MS_OGR && msOGRSupportsIsNull(lp))) &&
-        strcmp(psFilterNode->pszValue, "PropertyIsNull") == 0) {
+    if (lp->connectiontype == MS_POSTGIS ||
+        (lp->connectiontype == MS_OGR && msOGRSupportsIsNull(lp))) {
       msFree(psFilterNode->pszValue);
       psFilterNode->pszValue = msStrdup("PropertyIsEqualTo");
       psFilterNode->psRightNode = FLTCreateBinaryCompFilterEncodingNode();