Do not stop the server in onDisable #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or add a config option. Whichever you do, if I want to stop the server, I'll execute /stop myself.
|
Idk what github is doing to the whitespace up there, but I think you get the idea. |
|
I'm 90% sure that doesn't stop the minecraft server, just the internal web server that JPanel uses. |
|
I guess so. Taking a look at #9, it seems that something, probably in jetty or whatever, is stopping the server since it's being sent from another thread... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or add a config option. Whichever you do, if I want to stop the server, I'll execute /stop myself.