Request to incorporate CopperEggWriter configuration files into this repo #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tric groups and dashboards for monitoring your jvms and tomcat servers. copperegg_config.json is a config file specifically for the Cocktail App demo. copperegg_jmxtrans.json is also set up for the Cocktail App demo; copy it to jmxtrans.json, add your CopperEgg APIKey, and you are good to go.
|
jmxtrans project » embedded-jmxtrans-samples #63 SUCCESS |
…pperEgg content from src/main/resources; moved all copperegg samples and README.md to src/main/copperegg
|
jmxtrans project » embedded-jmxtrans-samples #65 SUCCESS |
added 2 commits
October 18, 2015 13:34
CE-1696 Replaced terminologies and URLs related to CopperEgg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello from Scott Johnson at CopperEgg.
As promised, this is a request for you to consider including the CopperEggWriter configuration files into the embedded-jmxtrans-samples repo.
embedded-jmxtrans-samples was forked, and CopperEggWriter configuration files added as needed by the CopperEggWriter. These configuration files have been made available publicly as a beta on github, and have been deployed by a few of our customers for a couple of weeks. As you will see, the code is provide under the MIT license, which is as liberal as your open-source licensing terms.
As for my CopperEggWriter submission, I have done everything I can think of to minimize any effort on your part to include these configuration files into embedded-jmxtrans-samples. As you can see on the CopperEgg fork ( https://github.com/CopperEgg/embedded-jmxtrans-samples ), your README.md is untouched; information about deploying embedded-jmxtrans and using the CopperEggWriter are included in a separate readme, README_CopperEgg.md.
These configuration files are in JSON format; configuration files are included to use CopperEggWriter along with your Cocktail Demo app (very cool!).
These configuration files make the deployment of embedded-jmxtrans + CopperEggWriter very straight-forward. Please consider incorporating these into this repo. CopperEgg would expect (and be happy) to maintain the CopperEggWriter.
I would be happy to make any and all modifications to the attached and readme that you deem necessary.
Thanks,
Scott Johnson
[email protected]