Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 10.6 Glyph Stats #44

Closed
AnnaDamm opened this issue Jan 19, 2016 · 13 comments
Closed

Add 10.6 Glyph Stats #44

AnnaDamm opened this issue Jan 19, 2016 · 13 comments

Comments

@AnnaDamm
Copy link

With Manufactury Breached, there are now 10.9 items with 10.6 glyphs.
Would it be possible to add the glyphs to the calculation?

@Xeio
Copy link
Contributor

Xeio commented Jan 19, 2016

Biggest problem is we are missing glyph values for the vast majority of 10.6 combinations.

Granted, several of the useful ones like hit/pen/crit (for 4/4 glyphs, for some slots) could theoretically be added.

@AnnaDamm
Copy link
Author

Maybe, until the stats are available, grey out the options to do the combinations that are unavailable? or make them "0". So you can already at calculate with the ones that are known?

@Inkraja
Copy link
Contributor

Inkraja commented Jan 21, 2016

The Game only contains 10.0-10.5 and 11 Glpyhs, so their values are known. 10.6-10.9 are not inside only as bound glyp on the mfa/b items, like the raid items.

@AnnaDamm
Copy link
Author

Then maybe the question is, if there is a way to add those items? Maybe In line with the NYR + Woodcutter items. At least currently they are THE most end-gamey items that you can get.
At some point I guess there is no more room for more checkboxes there and it gets more and more complicated..

@Inkraja
Copy link
Contributor

Inkraja commented Jan 21, 2016

Getting more checkboxes and switch them do a dropdown menu shouldnt a big problem. The only important questions is, if @joakibj want to do that 😸

@Xeio
Copy link
Contributor

Xeio commented Jan 21, 2016

I'd agree moving the checkboxe options into the dropdown is probably the best option, but it also requires rewriting a lot of tests and moving non-custom signet/glyph logic into the data for the dropdown options. We'd probably want to keep the list of gear in there somewhat trimmed as well, mostly to gear that can't be made from equivalent customs.

Personally I'm probably not particularly keen on doing any of that till we have new NM gear to account for (11.0 support is one of those needed things too, and I'd wager 10.6 custom glyphs come from at least one of the raids). Short term the PvP signets will need to be added as well, though they haven't been finalized yet so...

@joakibj
Copy link
Owner

joakibj commented Jan 21, 2016

Yeah dropdowns are probably the more scalable solution in the current GUI. e.g. select by role+slot+item name instead of role+slot+raid combination.

But to be clear, these items haven't started dropping yet? Just datamined from TestLive?
Also if anyone wants to dig around in the .rdbdata with for example tswrdb then I bet the actual items are defined somewhere in there. So they can be programmatically extracted like any other sane item database.

Regarding tests, they are important for protecting against regression, but user value comes first.

@Xeio
Copy link
Contributor

Xeio commented Jan 21, 2016

But to be clear, these items haven't started dropping yet? Just datamined from TestLive?

The dungeon Manufactory:Breached loot mentioned above (10.9 with 10.6 built-in glyphs and purple signet equivalents) is available on Live and has been looted. 2-3 per slot (one per role, though I haven't seen every role drop for every slot so I'm not sure which slots may not have all 3).

The new NM Raid items are in the Live data (including 10.9 varians of the old NY items), though obviously nobody has killed any NY raid content yet, so other than making a good guess at where 10.9 NY items come from we can't confirm much about them.

@joakibj
Copy link
Owner

joakibj commented Jan 21, 2016

Alright, any list out there with the Manufactory:Breached loot ?

@Xeio
Copy link
Contributor

Xeio commented Jan 21, 2016

I don't think anyone has compiled a list of the 10.9.6 loot, that would probably be work we have to do.

I have 4-5 of the pieces myself, could possibly ping cabalies for a lot of the others. Might be easier to ask for help getting a full list on the main forums though.

Oh, and I forgot there are 10.9.6 variants of every weapon too (though they all have a 10.6 Hit Glyph, so it's mostly which signet is built into each that would be needed).

@Inkraja
Copy link
Contributor

Inkraja commented Jan 21, 2016

PVP Signets are here (coming live, soon): https://docs.google.com/spreadsheets/d/11AOygXcnzmZHr9bdLmntGEUgCZWA9t5EdKGZYzYuNns/edit?usp=sharing
NM Raid Items, i have a similar Sheet, but i will never ever share it in public, and till the first NYR nm i try to keep the secrets as long as possible. ;)

The mfb Items have also signets. For example 10.8 AR with hit glyph and blue abuse, 10.9 AR with hit glyph and purple Abuse.
The Head DPS Piece is similar 10.8 with Pen glyph and blue Breaching, 10.9 with Hit glyph (yes 10.8 and 10.9 have a different glyph) and purple Breaching.

Xeio i can send u the ingame datamining script, but u need to know the item id's.

@Inkraja
Copy link
Contributor

Inkraja commented Jan 25, 2016

@Xeio
Copy link
Contributor

Xeio commented Feb 4, 2016

So a minor update on QL11 glyphs:

Currently 1/3 and 3/1 splits do not exist (So glyphs like 3 Crit Power, 1 Pen can't be made). I found this oddity in the data mining, but I confirmed it with Headshoty that the crafting window does not allow preview of those variants.

Have most of the stats collected and most of the code work done, so I basically just need to find time to put everything into the data file (and add handling to prevent selecting 1/3,3/1 variants).

@Xeio Xeio mentioned this issue Feb 5, 2016
joakibj added a commit that referenced this issue Feb 6, 2016
QL 11 Glyph Support. Fixes #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants