fix(error-handling): add http error handling (#8)

src/compute/coverage-for-folder.sh

@@ -1,5 +1,7 @@
 #!/usr/bin/env bash
 
+set -e
+
 # This script computes the test coverage for a list of folders
 
 echo

src/monitor/push-metrics-all-folders.sh

@@ -1,5 +1,7 @@
 #!/usr/bin/env bash
 
+set -e
+
 # This script push computed metrics to Prometheus.
 
 # It expects coverage metrics to be exposed in a tar.gz file called

src/monitor/push-metrics-for-folder.js

@@ -37,18 +37,13 @@ const pushMetricsForFolder = ({ coverageArtifactsPath, folderName, jobName, push
         .reduce((metricsAsText, metric) => metricsAsText + formatMetricPayload(metric), "")
 
     // Sent metrics to Prometheus
-    try {
-        pushToGateway(`${pushGatewayUri}/metrics/job/${jobName}/folder_name/${folderName}`, metricsPayload, (err, data) => {
-            if (err) {
-                throw new Error(err.message)
-            }
+    pushToGateway(`${pushGatewayUri}/metrics/job/${jobName}/folder_name/${folderName}`, metricsPayload, (err, data) => {
+        if (err) {
+            throw new Error(err.message)
+        }
 
-            console.log("Done -", data.body)
-        })
-    }
-    catch(e) {
-        throw new Error(`ERROR: ${e.message}`)
-    }
+        console.log("Done -", data.body)
+    })
 }
 
 // If script is used from command-line as standalone

src/monitor/push-to-pushgateway.js

@@ -25,6 +25,11 @@ const pushToGateway = (pushGatewayUri, metricsPayload, callback) => {
         res.setEncoding('utf8')
         res.on('data', chunk => body += chunk)
         res.on('end', () => {
+            if (res.statusCode > 204) {
+                callback(new Error(`Invalid response status code '${res.statusCode}' - response: ${body}`))
+                return
+            }
+
             callback(null, {
                 res,
                 body,