Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up legacy odb conversion #304

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix up legacy odb conversion #304

merged 1 commit into from
Jan 28, 2025

Conversation

bbrehm
Copy link
Contributor

@bbrehm bbrehm commented Jan 28, 2025

Another oops: We don't have unit tests in this repo for legacy odb conversion. Last PR broke that, and I only noticed in the codepropertygraph repo when bumping deps...

So this PR needs to go in to unbreak that. Afterwards: How do we want to deal with the unit test situation?

  1. Write new tests here
  2. copy/move over tests from the other repo
  3. document that this is an issue, so that we know to run that test next time we touch serialization code

@bbrehm bbrehm requested a review from mpollmeier January 28, 2025 14:21
@bbrehm bbrehm changed the title fix up legqacy odb conversion fix up legacy odb conversion Jan 28, 2025
@mpollmeier
Copy link
Contributor

Yes we should really have some tests here.
Given that odb is legacy and won't be change any more (as far as we can forsee now...), how about we add an odb database as a binary to src/resources, run odb2fg and verify some numbers.

There should also be some simple instructions on how we created that, which could be something like 'download joern version X and run ./joern-scan example-code and take the cpg.bin.

@bbrehm bbrehm merged commit 4b0057c into master Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants