Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and fix for issue #207 #222

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Test and fix for issue #207 #222

merged 2 commits into from
Feb 12, 2018

Conversation

TimSC
Copy link
Contributor

@TimSC TimSC commented Dec 4, 2017

Character encoding of query strings in python 3 makes the signature comparison fail. See issue #207.

@codecov-io
Copy link

codecov-io commented Dec 4, 2017

Codecov Report

Merging #222 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   96.05%   96.07%   +0.01%     
==========================================
  Files           5        5              
  Lines         482      484       +2     
==========================================
+ Hits          463      465       +2     
  Misses         19       19
Impacted Files Coverage Δ
oauth2/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6689960...281efc4. Read the comment docs.

@TimSC TimSC changed the title Test for issue #207 Test and fix for issue #207 Dec 4, 2017
@TimSC
Copy link
Contributor Author

TimSC commented Jan 13, 2018

I pulled this PR into a new fork: https://github.com/TimSC/python-oauth10a

@jaitaiwan jaitaiwan merged commit 5f364a3 into joestump:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants