Make Project runnable #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject), removed a unnecessary slash in server and client path. Changed parameters to my needs
…rmal value and updated surefire plugin version
…-open as it is not provided from any vendor anymore).
…ors while executing the qDup script).
Unsure how this project even ran because the jar that was built trough the buildCmd did not have the "-runner" suffix, and therefore the .jar could not get copied inside the docker container
… hardcoded in the pom.xml files anyways
… the dockerfiles anyways, and otherwise it will always be ignored because it does not have the -runner suffix
…chmark.yaml did not generate an Uber-Jar (outdated maybe?) with -DbuildUberJar=true, however i added the uber-jar package type to the pom.xml files and (again) modified the targetJar names (which now have the -runner affix due do the uber-jar). Now the .jar that is built with normal ./mvnw clean package is an uber-jar and can be executed without an manifest error. (maybe change this later to not be an uber-jar anymore, however then i have to also change the Dockerfile.jvm)
…chmark.yaml did not generate an Uber-Jar (outdated maybe?) with -DbuildUberJar=true, however i added the uber-jar package type to the pom.xml files and (again) modified the targetJar names (which now have the -runner affix due do the uber-jar). Now the .jar that is built with normal ./mvnw clean package is an uber-jar and can be executed without an manifest error. (maybe change this later to not be an uber-jar anymore, however then i have to also change the Dockerfile.jvm)
… setup applications (client-host, server-host, and machine to start the qDup Script from and generate the graphs; however this can also be done on the client-host and server-host themselves if they have good enough hardware).
merged master into project_runnable (added .dockerignore files)
…e data will be calculated wrong, because the files generated by top and wrk use a comma as decimal separator instead of a point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the project runnable after executing the steps listed in the README.MD, as there are some problems when you want to execute the benchmark.yaml script (mostly due to deprecations) after following the recommended setup:
Note: The commits are often redundant and a little bit over the place, as it often took me a while to find the error causes, sorry for that.
README.md
pom.xml
Dockerfile.jvm
VertxRoute.java
benchmark.yaml
timing.js