Feature/modify delete algorithm

serverless.yml

@@ -88,16 +88,16 @@ functions:
           method: delete
           cors: true
 
-  changeStatusAlgorithm:
-    handler: src/handler.setAlgorithmStatus
+  modifyAlgorithm:
+    handler: src/handler.modifyAlogirithemContent
     events:
       - http:
           path: algoirthm/{id}
           method: patch
           cors: true
 
-  modifyAlgorithm:
-    handler: src/handler.modifyAlogirithemContent
+  changeStatusAlgorithm:
+    handler: src/handler.setAlgorithmStatus
     events:
       - http:
           path: algoirthm/{id}/status
@@ -111,6 +111,7 @@ functions:
           path: verify
           method: get
           cors: true
+
   addVerify:
     handler: src/handler.addVerifyQuestion
     events:

src/DTO/algorithm.dto.ts

@@ -9,3 +9,5 @@ export type AlgorithmStatusType =
   | "ACCEPTED"
   | "REJECTED"
   | "REPORTED";
+
+export interface ModifyAlgorithmDTO extends BaseAlgorithmDTO {}

src/DTO/user.dto.ts

@@ -1 +1,5 @@
 export type IdentityType = "faculty" | "graduate" | "student";
+export interface DecodedAccessToken {
+  isAdmin: boolean;
+  email: string;
+}

src/middleware/auth.ts

@@ -1,18 +1,21 @@
 import { APIGatewayEvent } from "aws-lambda";
-import { getRepository } from "typeorm";
+import { getCustomRepository, getRepository } from "typeorm";
 
 import { ALLOWED_ORIGINS, createErrorRes, createRes } from "../util/http";
 import { verifyToken } from "../util/token";
 import { checkQuestionAnswer } from "../util/verify";
 import { User } from "../entity";
 import jwt, { JwtPayload } from "jsonwebtoken";
 import { issuer } from "../config";
+import { UserRepository } from "../repository/user";
+import { DecodedAccessToken } from "../DTO/user.dto";
 export class AuthMiddleware {
   static onlyOrigin(_: any, __: string, desc: PropertyDescriptor) {
     const originMethod = desc.value; // get function with a decorator on it.
     desc.value = async function (...args: any[]) {
       // argument override
       const req: APIGatewayEvent = args[0];
+
       const origin = req.headers.Origin || req.headers.origin;
       if (!ALLOWED_ORIGINS.includes(origin) && origin) {
         // ignore request from not allowed origin
@@ -126,4 +129,20 @@ export class AuthMiddleware {
       return originMethod.apply(this, args);
     };
   }
+  static onlyAdmin(_: any, __: string, desc: PropertyDescriptor) {
+    const originMethod = desc.value;
+
+    desc.value = async function (...args: any[]) {
+      const req: APIGatewayEvent = args[0];
+      const token: string = req.headers.Authorization;
+
+      const { email } = verifyToken(token) as DecodedAccessToken;
+      const userRepo = getCustomRepository(UserRepository);
+      const isAdmin = await userRepo.getIsAdminByEmail(email);
+
+      return isAdmin
+        ? originMethod.apply(this, args)
+        : createErrorRes({ errorCode: "JL002", status: 401 });
+    };
+  }
 }

src/repository/algorithm.ts

@@ -1,4 +1,5 @@
 import { EntityRepository, Repository } from "typeorm";
+import { ModifyAlgorithmDTO } from "../DTO/algorithm.dto";
 
 import { Algorithm } from "../entity";
 
@@ -11,4 +12,12 @@ export class AlgorithmRepository extends Repository<Algorithm> {
       .groupBy("algorithm.algorithmStatus")
       .getRawMany();
   }
+
+  async modifyAlgorithm(id: number, data: ModifyAlgorithmDTO) {
+    return this.update(id, data);
+  }
+
+  async deleteAlgorithm(id: number) {
+    return this.delete(id);
+  }
 }

src/repository/user.ts

@@ -0,0 +1,13 @@
+import { EntityRepository, Repository } from "typeorm";
+import { User } from "../entity/User";
+
+@EntityRepository(User)
+export class UserRepository extends Repository<User> {
+  async getIsAdminByEmail(email: string): Promise<boolean> {
+    return (
+      await this.createQueryBuilder("user")
+        .where("user.email = :email", { email })
+        .getOne()
+    ).isAdmin;
+  }
+}

src/router/algorithm/algorithm.service.ts

@@ -1,11 +1,13 @@
+import { APIGatewayEvent } from "aws-lambda";
 import { getCustomRepository, getRepository } from "typeorm";
 
 import { bold13, bold15, ruleForWeb, rules } from "../../config";
-import { BaseAlgorithmDTO } from "../../DTO/algorithm.dto";
+import { BaseAlgorithmDTO, ModifyAlgorithmDTO } from "../../DTO/algorithm.dto";
 import { Algorithm } from "../../entity";
 import { AlgorithmRepository } from "../../repository/algorithm";
 import { getLastPostNumber } from "../../util/algorithm";
 import { createErrorRes, createRes } from "../../util/http";
+import { isNumeric } from "../../util/number";
 
 export const AlgorithmService: { [k: string]: Function } = {
   writeAlgorithm: async ({ title, content, tag }: BaseAlgorithmDTO) => {
@@ -48,6 +50,30 @@ export const AlgorithmService: { [k: string]: Function } = {
       },
     });
   },
+  modifyAlgorithmContent: async (event: APIGatewayEvent) => {
+    const { id } = event.pathParameters;
+
+    if (!isNumeric(id)) {
+      return createErrorRes({ errorCode: "JL007" });
+    }
+
+    const data: ModifyAlgorithmDTO = JSON.parse(event.body);
+    const algorithmRepo = getCustomRepository(AlgorithmRepository);
+    return createRes({
+      body: await algorithmRepo.modifyAlgorithm(Number(id), data),
+    });
+  },
+  deleteAlgorithm: async (event: APIGatewayEvent) => {
+    const { id } = event.pathParameters;
+
+    if (!isNumeric(id)) {
+      return createErrorRes({ errorCode: "JL007" });
+    }
+
+    const algorithmRepo = getCustomRepository(AlgorithmRepository);
+    await algorithmRepo.deleteAlgorithm(Number(id));
+    return createRes({});
+  },
 };
 
 const checkArgument: Function = (...args: any[]): boolean => {

src/router/algorithm/index.ts

@@ -9,7 +9,7 @@ export class AlgorithmRouter {
   static async getAlgorithmCountAtAll(_: APIGatewayEvent, __: any) {
     return AlgorithmService.getAlgorithmCountAtAll();
   }
-  
+
   static async getAlgorithmRules(_: APIGatewayEvent, __: any) {
     return AlgorithmService.getAlgorithmRules();
   }
@@ -27,9 +27,22 @@ export class AlgorithmRouter {
   static async wirteAlgorithm(event: APIGatewayEvent, _: any, __: Function) {
     return AlgorithmService.writeAlgorithm(JSON.parse(event.body));
   }
-  
+
   static async setAlgorithmStatus() {}
-  static async modifyAlgorithmContent() {}
+
+  @AuthMiddleware.onlyOrigin
+  @DBMiddleware.connectTypeOrm
+  @AuthMiddleware.onlyAdmin
+  static async modifyAlgorithmContent(event: APIGatewayEvent, _: any) {
+    return AlgorithmService.modifyAlgorithmContent(event);
+  }
+
   static async reportAlgorithm() {}
-  static async deleteAlgorithm() {}
+
+  @AuthMiddleware.onlyOrigin
+  @DBMiddleware.connectTypeOrm
+  @AuthMiddleware.onlyAdmin
+  static async deleteAlgorithm(event: APIGatewayEvent, _: any) {
+    return AlgorithmService.deleteAlgorithm(event);
+  }
 }

src/util/http.ts

@@ -17,6 +17,7 @@ export const ERROR_CODE_LIST: { [key in ErrorCodeType]: string } = {
   JL004: "예상치 못한 에러입니다. 개발자에게 문의해주세요.",
   JL005: "Token 값을 찾을수 없습니다.",
   JL006: "Token 인증이 실패하였습니다.",
+  JL007: "잘못된 요청입니다.",
 } as const;
 
 export type ErrorCodeType =
@@ -25,7 +26,8 @@ export type ErrorCodeType =
   | "JL003"
   | "JL004"
   | "JL005"
-  | "JL006";
+  | "JL006"
+  | "JL007";
 
 export const createRes = ({
   statusCode,

src/util/number.ts

@@ -0,0 +1,2 @@
+export const isNumeric: Function = (data: string): boolean =>
+  !isNaN(Number(data));