Refactor/separating files #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iseolin76
reviewed
Apr 28, 2022
| ).report(userData.subId, numericId) | ||
| : 1; | ||
| })() | ||
| : 1; |
There was a problem hiding this comment.
삼항 연산자 중복보다는 if else 문을 쓰는 게 더 좋지 않을까요?
There was a problem hiding this comment.
if else가 아닌 ||는 어떨까요
There was a problem hiding this comment.
changeStatus === "REPORTED" && await (async () => {
await algorithmRepo.setAlgorithmStatus(numericId, reason, "REPORTED");
!!userData.subId && getCustomRepository(
ReportAlgorithmRepository,
event.connectionName,
).report(userData.subId, numericId)
})();There was a problem hiding this comment.
if(changeStatus === "REPORTED"){
await algorithmRepo.setAlgorithmStatus(numericId, reason, "REPORTED");
!!userData.subId && getCustomRepository(
ReportAlgorithmRepository,
event.connectionName,
).report(userData.subId, numericId)
}이런 형태도 괜찮을려나요
Co-authored-by: Seolin <[email protected]>
…im/Bamboo-API into refactor/Separating_files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
파일 분할