Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add : TypeORM ERD매핑 #3

Merged
merged 3 commits into from
Nov 17, 2021
Merged

add : TypeORM ERD매핑 #3

merged 3 commits into from
Nov 17, 2021

Conversation

louis7308
Copy link
Contributor

TypeORM으로 ERD매핑시켜 Entities들 작성했습니다.

sunrabbit123
sunrabbit123 requested changes Nov 13, 2021
View reviewed changes
Copy link
Member

@sunrabbit123 sunrabbit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가로 모델들을 넣어놓은 폴더의 이름은
폴더 자체가 여러 파일들을 모아놓은 복수형이기에 단수로 서술하는 것이 좋으며
몇 몇 쉘에서는 대소문자를 가리지않기도 하기때문에 전부 소문자로 서술하는 것이 좋습니다. (ex : cmd)

따라서 model 또는 entity라는 이름을 추천합니다.

sunrabbit123
sunrabbit123 reviewed Nov 15, 2021
View reviewed changes
Copy link
Member

@sunrabbit123 sunrabbit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자잘한 사항들 수정이 안된 것 같으니 체크해주세용

@louis7308 louis7308 merged commit 5a4bf85 into main Nov 17, 2021
@louis7308 louis7308 deleted the feature/model branch November 17, 2021 10:59
louis7308 added a commit that referenced this pull request Nov 17, 2021
@louis7308
Revert "Merge pull request #3 from joog-lim/feature/model"
a4b26ec 
This reverts commit 5a4bf85, reversing
changes made to 07036f9.
@louis7308 louis7308 restored the feature/model branch November 17, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunrabbit123 sunrabbit123 sunrabbit123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis7308 @sunrabbit123