Create Token #9
Merged
Create Token #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
louis7308
commented
Dec 17, 2021
louis7308
commented
- Oauth2 연동 작업 개발 완료
- 대나무숲 전용 JWT 개발 완료
- JWT 생명유지 / 인증 개발 완료
- 기존 유저가 다시 로그인 했을때 DB값을 추가하지 않고 UPDATE해서 값을 추가 개발 완료
- 학교 이메일하고 지금 년도 비교 해서 학생인지 판단하는거 개발 완료
sunrabbit123
requested changes
Dec 17, 2021
sunrabbit123
approved these changes
Dec 22, 2021
src/middleware/auth.ts
Outdated
| if(accessToken === null) { | ||
| if(refreshToken === null) { | ||
| return createErrorRes({ | ||
| errorCode: ERROR_CODE.JL001, |
There was a problem hiding this comment.
에러코드 JL001은 옳지않은 Origin일때 나타나는 에러입니다
새로 에러 코드를 선언해서 작성해주시길 바랍니다.
src/middleware/auth.ts
Outdated
| const decodeAccessToken: string | JwtPayload = await jwt_decode(req.headers.accessToken) | ||
| const refreshToken: string | JwtPayload = await decodeToken(req.headers.refreshToken) | ||
| const repo = getRepository(User); | ||
| const id = await repo.find({ |
There was a problem hiding this comment.
유저의 id 조회는 필요할때만 조회해도 된다고 생각합니다.
if문 안쪽으로 넣는건 어떨까요?
src/router/auth/index.ts
Outdated
| const tokens : any = event.headers.id_token; | ||
| if(!tokens) { | ||
| return createErrorRes({ | ||
| errorCode: ERROR_CODE.JL004, |
There was a problem hiding this comment.
JL004는 예상치못한 에러를 의미합니다.
새로 에러를 선언해서 작업해주시길 바랍니다.
참고 util/http.ts
src/util/http.ts
Outdated
| }; | ||
| }; | ||
|
|
||
| export const decodeToken = (token : string) : null | string | JwtPayload => { |
There was a problem hiding this comment.
http.ts보다는 token.ts가 어울릴 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.