Fix various issues #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The append method of buffer causes an error (Vim 7.3 with Python 2.7.3) if the supplied list is empty. This case is now handled explicitly.
The previous implementation causes a problem (Vim 7.3 with Python 2.7.3) with obtaining the buffer object of a newly generated buffer. This is fixed by a more straightforward approach.
The commands ':Do' and ':DoQuietly' now tab-complete filenames, which is essential when dealing with shell commands.
Fix Issue #1 concerning missing lines in the output buffer. We simply have to continue to read from the streams (after the process has terminated) until we hit the end-of-file.
|
This now includes the fix to Issue #1. |
Remove some obsolete lines, which searched for the Python sources in the wrong place. Prepare to use the Python 3 interface, the code still has to be updated in other places.
Make scripts compliant to Python 3, the code still has to be updated in other places.
Extend the handling of processes in Python: - Allow to split the output. - Processes can be marked as 'external', - ... and trigger the new hook 'do#HookProcessFinished' upon completion. - Move 'Process' creation from 'ProcessCollection' into the 'Do' class. Add an API, so that 'do.vim' can be triggered by other plug-ins: - Processes can be started via 'do#ExecuteExternal', ... which support a callback executed upon the completion of the background process. - Information about them can be retrieved via 'do#GetExternal'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed various issues I had when running under Vim 7.3 with Python 2.7.3.
VimBuffer.writewas correct in the case whereoverwrite == trueandlen(to_write) == 1 and to_write[0] == ""were both true. The buffer would not have been overwritten with the new empty content in this case.buffer_number()anymore. (From my experience with my own plug-ins, this whole family of functionsbufnr(),winnr(), ... is not without problems, so it is nice if you can avoid them.)