Full refactoring of shell config handling w/o globals #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* lib: refactor to use enum class for events * lib: pass auto-reconnect behavior on disconnect * shell: split wp initialization from connecting * pass wp, wpdef into WattpilotShell BREAKING CHANGEs: * rename cmd get/set to propget/set (conflict with built-in cmd)
* no more globals for configs that clutter the code * refactoring-safe config parameter references * new shell commands 'config' and 'docs' * move env var docs to separate auto-generated file * update env var docs using './test-shell.sh update-docs'
|
@joscha82 any chance that this PR get merged? |
|
@ahochsteger yes! sorry - was busy in the last weeks. Will merge the backloads now / next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES: