Ensure rect is rounded correctly #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug introduced in joshwnj#116, which introduced rounding on the element rect. When a `containment` is specified that itself has non-integer values in its bounding rect, you get a rounding issue as `top` and `left` will be floored, causing them to go out of the containment bounding rect. Say you have a container element with `left: 100.5` and the element rect at `left: 100.5` as well; this then gets rounded down to `left: 100`, meaning it is no longer considered completely visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #116, which introduced rounding on the element rect. When a
containmentis specified that itself has non-integer values in its bounding rect, you get a rounding issue astopandleftwill be floored, causing them to go out of the containment bounding rect.Say you have a container element with
left: 100.5and the element rect atleft: 100.5as well; this then gets rounded down toleft: 100, meaning it is no longer considered completely visible.