-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename tilt to pinch #45
Conversation
Thanks for the pull request @gabbopalma! We can either add it to the breaking v0.1.2 release or by adding deprecations to the public API add it directly to the v0.0.2 feature release. As you wish. 👍 |
I think introducing deprecations in the public API means adding double references to the tilt and pitch properties. This would also mean managing which one to select in their use cases. |
After some time thinking about it, I'd love to release it already with the next 0.0.2 release (sorry about the type in my last message, the breaking release will be 0.1.0 😄). Otherwise the newly added max/min tilt parameters would be renamed immediately. And keeping this pull request up-to-date with the main branch could be trickly. |
Alright, should be ready to merge now. Sorry for asking for what you prefer and then not going with it. The pull request came just in the right time.😅 |
Don't worry, your choice is definitely good for the purposes of the project. I will see the improvements of the deprecations, I am curious to see what changed ahah. |
- [X] rename all tilt references to pinch - [X] update CHANGELOG.md - [X] update comments for tilt / pinch Closes a task of josxha#22 --------- Co-authored-by: Joscha <[email protected]>
Closes a task of #22